Ticket #1458 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

FileProperty returns a non-empty string even if nothing is typed in in the GUI

Reported by: Janik Zikovsky Owned by: Martyn Gigg
Priority: critical Milestone: Iteration 24
Component: Keywords:
Cc: pf9@…, scu@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Steps to reproduce:

  • Launch MantidPlot
  • Execute LoadEventPreNexus
  • Clear all the filenames.
  • Click run.

Look in the Results log window: You will see this:

Algorithm: LoadEventPreNeXus v1 Parameters:

Name: EventFilename, Value: /home/janik/Code/Mantid/Code/Mantid/release/, Default?: No, Direction: Input Name: PulseidFilename, Value: /home/janik/Code/Mantid/Code/Mantid/release/, Default?: No, Direction: Input Name: MappingFilename, Value: /home/janik/Code/Mantid/Code/Mantid/release/, Default?: No, Direction: Input Name: InstrumentFilename, Value: /home/janik/Code/Mantid/Code/Mantid/release/, Default?: No, Direction: Input

... so all the empty filenames were converted to the path where mantidplot lives (although I launched from /home/janik/Code/Mantid/Code/Mantid/debug/ ) so I don't know why it points there.

This later causes a maddening error in LoadEventPreNeXus if the mapping filename is not specified (it tries to load the folder or something)

Martyn, I assigned it to you since you last touched FileProperty, but I'm not sure if you are responsible for it; please reassign as needed.

Change History

comment:1 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Martyn Gigg

(In [5583]) Fix FileProperty's handling of empty value strings and update test. Re #1458

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify

comment:4 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:5 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:6 Changed 10 years ago by Nick Draper

  • Status changed from closed to verify

moved to verify

comment:7 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying

comment:8 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:9 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2305

Note: See TracTickets for help on using tickets.