Ticket #1491 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Modify Direct Geometry Inelastic scripts to work for SNS instruments

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

A ticket to track the changes made in order to get the direct geometry energy conversion scripts to work for the SNS instruments.

Will need to be revisited in the next iteration

Change History

comment:1 Changed 10 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Stuart Campbell

(In [5722]) Altered order of parameters on do_conversion() and convert_to_energy() so that we can make the white_run optional. refs #1491

comment:3 Changed 10 years ago by Stuart Campbell

(In [5723]) Add extra clause for .dat files (which will point to event files at the moment) in load_run(). refs #1491

comment:4 Changed 10 years ago by Martyn Gigg

(In [5731]) Updated direct ConvertToEnergy GUI to reflect script argument order changes. Re #1491

comment:5 Changed 10 years ago by Stuart Campbell

(In [5734]) Sort of works for CNCS now. refs #1491

comment:6 Changed 10 years ago by Martyn Gigg

(In [5744]) Remove a print statement that will cause the GUI to think there has been an error. Re #1491

comment:7 Changed 10 years ago by Stuart Campbell

(In [5754]) Convert T0 from millisec to microsec and offset bins in opposite direction. refs #1491

comment:8 Changed 10 years ago by Stuart Campbell

(In [5839]) Removed time bins from class. Now for events, convert to Et, histogram then go back to tof. Added reading of ARCS/SEQUOIA monitors and call GetEi. refs #1491

comment:9 Changed 10 years ago by Martyn Gigg

(In [5847]) Fix problem with empty map file on direct ConvertToEnergy interface. Re #1491

comment:10 Changed 10 years ago by Martyn Gigg

(In [5851]) Fix a couple or minor bugs that prevented the convert to energy scripts functioning for ISIS instruments. Re #1491

comment:11 Changed 10 years ago by Stuart Campbell

(In [5865]) More hacks for ARCS/SEQ. refs #1491

comment:12 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

Works as well as it is going to for this iteration.

comment:13 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:14 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

This is sufficient for the current iteration. In the future the hacks will be removed and we'll integrate both approaches as they are very similar.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2335

Note: See TracTickets for help on using tickets.