Ticket #1522 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Add use of helper method to get instrument geometry filename in algorithms

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Look through the code to see where we are manually constructing the instrument definition filename and replace by a call to the helper function ConfigService::getInstrumentFilename().

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Stuart Campbell
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Stuart Campbell

  • Component set to Mantid
  • Milestone changed from Iteration 25 to Iteration 26

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:4 Changed 10 years ago by Stuart Campbell

  • Milestone changed from Iteration 27 to Iteration 28

comment:5 Changed 10 years ago by Stuart Campbell

(In [10324]) Remove ugly hack to look for long instrument names. Just use the Facility/Instrument in the ConfigService. refs #1522

comment:6 Changed 10 years ago by Stuart Campbell

(In [10325]) Changed SANSInstrumentCreationHelper:runLoadInstrument() to now use the LoadInstrumentHelper. refs #1522

comment:7 Changed 10 years ago by Stuart Campbell

(In [10327]) Specifying facility to fix tests. refs #1522

comment:8 Changed 10 years ago by Stuart Campbell

(In [10328]) Specifying facility to fix tests. refs #1522

comment:9 Changed 10 years ago by Stuart Campbell

(In [10329]) Forgot to add the Mantid:: namespace. refs #1522

comment:10 Changed 10 years ago by Stuart Campbell

(In [10330]) Revert back for tonight. refs #1522

comment:11 Changed 10 years ago by Mathieu Doucet

(In [10340]) Updated Facilities.xml for SANS instruments Re #1522

comment:12 Changed 10 years ago by Stuart Campbell

(In [10363]) Make sure we set the facility in the tests. refs #1522

comment:13 Changed 10 years ago by Stuart Campbell

(In [10364]) Revert to hardcoded SANS test instrument for now. refs #1522

comment:14 Changed 10 years ago by Stuart Campbell

(In [10365]) Make sure we set the facility in the tests. refs #1522

comment:15 Changed 10 years ago by Stuart Campbell

(In [10366]) Make sure we set the facility in the tests. refs #1522

comment:16 Changed 10 years ago by Stuart Campbell

(In [10367]) Remove ugly hack to get long instrument names in getInstrumentFilename(). Make sure we set the facility in the tests. Modify ConvertUnitsTest to account for fixed bug in correctly determining instrument long name for MARI. refs #1522 & #2730

comment:17 Changed 10 years ago by Stuart Campbell

(In [10371]) Make sure we set the facility in the tests. refs #1522

comment:18 Changed 10 years ago by Stuart Campbell

(In [10375]) Make sure we set the facility in the tests. refs #1522

comment:19 Changed 10 years ago by Stuart Campbell

(In [10376]) Make sure we set the facility in the tests. refs #1522

comment:20 Changed 10 years ago by Stuart Campbell

(In [10377]) Make sure we set the facility in the tests. refs #1522

comment:21 Changed 10 years ago by Stuart Campbell

(In [10378]) Make sure we set the facility in the tests. refs #1522

comment:22 Changed 10 years ago by Stuart Campbell

(In [10379]) Make sure we set the facility in the tests. refs #1522

comment:23 Changed 10 years ago by Stuart Campbell

(In [10380]) Re-insert hack back as this seems to break lots of things. The problem is being caused by relying on NOT finding the instrument definition and loading the info from the RAW files instead. We should fix this, if people need to load from the RAW file they should do it explicitly. refs #1522

comment:24 Changed 10 years ago by Stuart Campbell

(In [10381]) I give up for the moment. Change back to the value determined from RAW file. refs #1522 & #2730

comment:25 Changed 10 years ago by Stuart Campbell

(In [10441]) Make sure we set the facility in the tests. refs #1522

comment:26 Changed 10 years ago by Stuart Campbell

(In [10442]) Make sure we set the facility in the tests. refs #1522

comment:27 Changed 10 years ago by Stuart Campbell

(In [10443]) Make sure we set the facility in the tests. refs #1522

comment:28 Changed 10 years ago by Stuart Campbell

(In [10445]) Let's try again. refs #1522 & #2730

comment:29 Changed 10 years ago by Stuart Campbell

  • Status changed from assigned to accepted

comment:30 Changed 10 years ago by Mathieu Doucet

(In [10478]) Added HFIR to facility list. Re #1522

comment:31 Changed 10 years ago by Russell Taylor

(In [10481]) Attempt to fix broken test (under scons) on linux buildserver by setting facility. Re #1522.

comment:32 Changed 10 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:33 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:34 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to closed

Seems to be working. Before this, if I used MantidPlot and I set the facility, I had to delete my mantid profile in order for the tests to run. Now it's no problem

comment:35 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2369

Note: See TracTickets for help on using tickets.