Ticket #1550 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

ICAT Search Interface - Validation

Reported by: Michael Whitty Owned by: Sofia Antony
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

re #1530

the message is only passed to the "Results Log" pane, invalid input is not highlighted on the dialog and if user isn't paying attention to results pane or doesn't have it open, there would be nothing to tell them that the process hasn't (or isn't in the process of) running, and they may believe that the run button is merely unresponsive. I'd suggest either a popup (the MantidCustomInterface class provides showInformationBox function that serves this purpose well), or some sort of highlighting of invalid input such as exists in other interfaces.

Change History

comment:1 Changed 10 years ago by Sofia Antony

  • Status changed from new to accepted
  • Component set to Mantid

comment:2 Changed 10 years ago by Sofia Antony

(In [6159]) re#1550 - Added a new class to validate start and end dates for ICat algorithms.

comment:3 Changed 10 years ago by Sofia Antony

(In [6255]) re#1550 - Date validator code is moved to .cpp file and date validator is added to search and advance search algorithms

comment:4 Changed 10 years ago by Sofia Antony

(In [6256]) re#1550 - fix for Linux build failure , C runtime library atoi is replaced with boost::lexical_cast

comment:5 Changed 10 years ago by Sofia Antony

(In [6257]) re#1550 - validators added for icat search and advanced search dialogs

comment:6 Changed 10 years ago by Sofia Antony

  • Status changed from accepted to verify
  • Resolution set to fixed

In MantidPlot if an error occurs when an algorithm is running Results window will be opened automatically and error message will be printed in red colour. I think this gives enough information to the user that the process is not running,which input is invalid etc and with this approach user can save one mouse click i.e;closing the information box. However I've added validators for ICat search interface and also added a error message on the ICat search results display.

comment:7 Changed 10 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:8 Changed 10 years ago by Russell Taylor

(In [7149]) Corrected a typo and shortened the message because it didn't fit in the window for me. Re #1550.

comment:9 Changed 10 years ago by Russell Taylor

  • Status changed from verifying to closed

Checks out in [7143].

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2397

Note: See TracTickets for help on using tickets.