Ticket #1570 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create ISIS SANS command interface module and Reducer

Reported by: Mathieu Doucet Owned by: Steve Williams
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Stephen.williams@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Start refactoring the ISIS SANS reduction code by creating an ISIS-specific command interface along the lines of CommandInterface.py.

Implement a Reducer class for the ISIS SANS instruments to extend the the current SANSReducer if it doesn't suffice.

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

(In [6008]) Started organizing ISIS SANS code. Added ISIS Reducer (incomplete and rough), command interface, ReductionSteps and unit tests. Re #1570

comment:2 Changed 10 years ago by Mathieu Doucet

(In [6027]) Small step forward on prototyping ISIS SANS reduction with our new design. Re #1570

comment:3 Changed 10 years ago by Mathieu Doucet

(In [6054]) Added the setup part of AssignCan. Re #1570

comment:4 Changed 10 years ago by Steve Williams

  • Cc Stephen.williams@… added

comment:5 Changed 10 years ago by Mathieu Doucet

(In [6066]) Added tests for AssignCan. Re #1570

comment:6 Changed 10 years ago by Steve Williams

(In [6099]) Created a SANS SampleGeomCor reduction step and associated commands. Depending on HFIR this might want to move out of the top level SANSReductionStep area. Basic testing included more to follow re #1570

comment:7 Changed 10 years ago by Mathieu Doucet

(In [6107]) A little clean up. Fixed some tests. Re #1570

comment:8 Changed 10 years ago by Mathieu Doucet

(In [6126]) Started to implement WavRangeReduction. Re #1570

comment:9 Changed 10 years ago by Steve Williams

(In [6136]) Testing a SANS reduction under the new framework! re #1570

comment:10 Changed 10 years ago by Steve Williams

(In [6200]) Copied most of the SANS code out of SANSReduction re #1570

comment:11 Changed 10 years ago by Steve Williams

(In [6201]) Two more SANS modules re #1570

comment:12 Changed 10 years ago by Mathieu Doucet

(In [6210]) Call Clear() from within the instrument declaration command instead of the module import to allow instrument switching between instrument types. Re #1570

comment:13 Changed 10 years ago by Steve Williams

(In [6225]) Moving the SANS reduction into the new framework re #1570

comment:14 Changed 10 years ago by Mathieu Doucet

  • Owner changed from Mathieu Doucet to Steve Williams
  • Status changed from new to assigned
  • Component set to Mantid

comment:15 Changed 10 years ago by Steve Williams

  • Status changed from assigned to accepted

comment:16 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

It should now be possible to complete a SANS analysis from Python without importing SANSReduction. To access the required commands load the libraries like so:

from ISISCommandInterface import *
from SANSBatchMode import *

comment:17 Changed 10 years ago by Steve Williams

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:18 Changed 10 years ago by Steve Williams

  • Status changed from reopened to accepted

comment:19 Changed 10 years ago by Steve Williams

(In [7141]) It is possible to do a SANS reduction using the new Python framework except for beam centre finding and batch mode which are not working yet. The remaining functionality will be implemented under ticket #1686 re #1570

comment:20 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:21 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:22 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Duplicate of #1686

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2417

Note: See TracTickets for help on using tickets.