Ticket #1590 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Load SNS event NeXus files

Reported by: Peter Peterson Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

The files to be read are still in development, but this ticket is to hold a place for working on reading them in.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Peter Peterson
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Janik Zikovsky

  • Status changed from assigned to accepted
  • Owner changed from Peter Peterson to Janik Zikovsky
  • Component set to Mantid

comment:3 Changed 10 years ago by Janik Zikovsky

(In [6569]) Refs #1590: First check-in of LoadSNSEventNexus; I don't have a (good) test file, so the test is disabled for now.

comment:4 Changed 10 years ago by Janik Zikovsky

(In [6596]) Refs #1590: Fixed SNSEventNexus loading code for the latest version. Added CNCS test data and updated test.

comment:5 Changed 10 years ago by Janik Zikovsky

(In [6597]) Refs #1590: Fix test build.

comment:6 Changed 10 years ago by Janik Zikovsky

(In [6599]) Refs #1590: Added a PARALLEL_FOR_IF openmp macro to handle any condition. Used it in LoadSNSEventNexus so that the Mac build doesn't die.

comment:7 Changed 10 years ago by Janik Zikovsky

(In [6601]) Refs #1590: Added an include to make the windows test work. Put NXS loading code in a PARALLEL_CRITICAL block, making that thread safe (and faster!)

comment:8 Changed 10 years ago by Janik Zikovsky

(In [6607]) Refs #1590, #1588: Added support for time zone marker in ISO8601 date and time strings. Added test for that. Changed 'ProtonCharge' to 'proton_charge' in LoadEventPreNeXus in order to match what the DASLogs gives. Pulse times for events in LoadSNSEventNexus are set - need more testing though.

comment:9 Changed 10 years ago by Janik Zikovsky

(In [6615]) Refs #1590: Fixed pulse times for both LoadEventPreNexus and LoadSNSNexus. Added correct functions to TimeSeriesProperty.

comment:10 Changed 10 years ago by Janik Zikovsky

(In [6632]) Refs #1590: This should finally fix the test.

comment:11 Changed 10 years ago by Janik Zikovsky

(In [6664]) Refs #1590: Re-enabled ConjoinWorkspaces test; fix to SNSEventNexus in the event of 0-length pulse list.

comment:12 Changed 10 years ago by Janik Zikovsky

(In [6665]) Refs #1590: LoadSNSEventNexus: Parallel re-enabled, better progress reporting, optional filter by time of flight when loading.

comment:13 Changed 10 years ago by Janik Zikovsky

(In [6850]) Refs #1590: Added a start/stop time filter for LoadSNSEventNexus.

comment:14 Changed 10 years ago by Janik Zikovsky

(In [6911]) Refs #1590: Made the DAS logs load before the instrument to allow for parametrized instruments.

comment:15 Changed 10 years ago by Janik Zikovsky

(In [6912]) Refs #1590: Fix test.

comment:16 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

This has been working reliably for weeks now.

comment:17 Changed 10 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:18 Changed 10 years ago by Vickie Lynch

  • Status changed from verifying to closed

LoadSNSEventNexus is the same as loading prenexus files, but much faster. Reading data from DAS logs works for moving instruments.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2437

Note: See TracTickets for help on using tickets.