Ticket #1593 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Fix GetDetectorOffsets and add validators and a unit test

Reported by: Russell Taylor Owned by: Vickie Lynch
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

GetDetectorOffsets is broken since some stickler added a const to a workspace pointer that's passed to a sub-algorithm in check-in [5142]. This algorithm could also use some validators because a number of mandatory parameters have none.

Change History

comment:1 Changed 10 years ago by Russell Taylor

A unit test for this algorithm would be a good idea as well. And its inclusion in a system test.

comment:2 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted

comment:3 Changed 10 years ago by Russell Taylor

(In [6068]) Remove const from input workspace pointer so that it can be passed to sub-algorithm. Re #1593.

comment:4 Changed 10 years ago by Russell Taylor

(In [6976]) Add unit validation to GetDetectorOffsets. Re #1593.

comment:5 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to assigned
  • Owner changed from Russell Taylor to Vickie Lynch
  • Component set to Mantid
  • Summary changed from Fix GetDetectorOffsets and add validators to Fix GetDetectorOffsets and add validators and a unit test

I'm handing this off as I really don't know enough about it to write a sensible unit test.

Also, although I would like to add more validators I'm concerned that some users of this algorithm might be relying on the defaults being as they are even if it doesn't seem sensible.

comment:6 Changed 10 years ago by Vickie Lynch

  • Status changed from assigned to accepted

comment:7 Changed 10 years ago by Vickie Lynch

(In [7089]) Refs #1593 Added validators and a unit test for GetDetectorOffsets

comment:8 Changed 10 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

Validators and test work for PG3 data.

comment:9 Changed 10 years ago by Russell Taylor

(In [7110]) Delete (extremely large) workspaces at end of tests. Re #1593.

comment:10 Changed 10 years ago by Russell Taylor

(In [7114]) Disable execution test for now - assume this is the cause of the following test bad_allocing. Also add tests for the simple bits, mainly because cxxtest doesn't like test files with no tests in them. Re #1593.

comment:11 Changed 10 years ago by Martyn Gigg

(In [7166]) Enable GetDetectorOffsetsTest to be able to run on its own. Re #1593

comment:12 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:13 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified the unit test runs and is not a sensible size. Output cal file seems sensible when tested with HRP39191.

comment:14 Changed 10 years ago by Martyn Gigg

Previous comment was supposed to say 'unit tests are using a sensible size workspace now' not that they are not of a sensible size!

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2440

Note: See TracTickets for help on using tickets.