Ticket #1640 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Centre point rebinning

Reported by: Nick Draper Owned by: Alex Buts
Priority: major Milestone: Iteration 27
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Implement most basic dynamic rebinning realisation (Centre Point Rebinning). Include the ability to process Implicit functions.

Change History

comment:1 Changed 10 years ago by Alex Buts

(In [6744]) refs #1640 modifications allowing to register MDworkspace to factory and attempted CPrebinning initialisation;

comment:2 Changed 10 years ago by Alex Buts

(In [6813]) refs #1640 minor modifications to the code and CP rebinning stub

comment:3 Changed 10 years ago by Alex Buts

(In [7266]) refs #1637 refs #1640 rough CP rebinning code and workspace which works with CP rebinning. needs further testing, especially for proper reshaping.

comment:4 Changed 10 years ago by Alex Buts

(In [7293]) refs #1640 minor modifications to a running CP algorithm -- will look nice.

comment:5 Changed 10 years ago by Alex Buts

(In [7300]) refs #1640 changes to project chain to allow copying MDDataObject libraries under Mantid

comment:6 Changed 10 years ago by Alex Buts

(In [7313]) refs #1640 MDPropertyGeometry has been reincarnated as a property with value

comment:7 Changed 10 years ago by Alex Buts

(In [7314]) refs #1640 MDPropertyGeometry modifications to satisfy gcc

comment:8 Changed 10 years ago by Alex Buts

(In [7317]) refs #1640 MDPropertyGeometry modifications to work correctly

comment:9 Changed 10 years ago by Alex Buts

(In [7357]) refs #1640 MDPropertyGeometry fully controlled by property manager and the CPR algorithm fully utilises this.

comment:10 Changed 10 years ago by Alex Buts

(In [7358]) refs #1640 MDPropertyGeometry modified to satisfy Linux (hopefully).

comment:11 Changed 10 years ago by Alex Buts

(In [7383]) refs #1640 refs #1637 Almost all code from the MD workspaces moved to CPrebinning algorithm. Memory corruption as a result, but should compile.

comment:12 Changed 10 years ago by Alex Buts

(In [7398]) refs #1640 refs #1637 rebinding code has been moved into cpr rebining class. All works so far -- some tests still be useful for rebinning.

comment:13 Changed 10 years ago by Alex Buts

(In [7536]) refs #1637 documents and CP rebinding modified according to changes in MDWorkspace refs #1640 CP modified according to MD workspace but fails on file property and MDWorskpace property

comment:14 Changed 10 years ago by Alex Buts

(In [7541]) refs #1640 All works in 4D but more tests and expansion on MxN D is still due.

comment:15 Changed 10 years ago by Alex Buts

(In [7612]) refs #1640 committed test project for CP rebinning

comment:16 Changed 10 years ago by Alex Buts

(In [7613]) refs #1640 and actual CP rebinning test

comment:17 Changed 10 years ago by Alex Buts

(In [7627]) refs #1640 CPR build for N-D and 3 reciprocal dimensions but further tests are needed to verify and implement for n_reciprocal< 3.

comment:18 Changed 10 years ago by Alex Buts

(In [7629]) refs #1640 minor changes to keep mac happy

comment:19 Changed 10 years ago by Alex Buts

(In [7630]) refs #1640 included float.h in MDGeometry.h May this will resolve the problem with MAC

comment:20 Changed 10 years ago by Alex Buts

(In [7638]) refs #1640 minor changes to rebinning functions making them more suitable for IRebinning implementation

comment:21 Changed 10 years ago by Alex Buts

(In [7860]) refs #1640 MD algorithms updated according to recent changes to MDGeometry and MDWorspace. compiles but rebinning test do not work as logic has not been updated.

comment:22 Changed 10 years ago by Alex Buts

(In [7869]) refs #1640 File format factory has been build to provide data loading for MD workspaces and Rebinning algorithms

comment:23 Changed 10 years ago by Alex Buts

(In [8056]) refs #1640 DynamicRebinFromXML works again after changing to the interface for MDDimensionDescription

comment:24 Changed 10 years ago by Alex Buts

(In [8088]) refs #1640; refs #2024 rebinning works on Horace files; Rebinning from Matlab differs from rebinning from Horace original

refs #1636 MDWorkspace classes work with IMDDimension rather then with MDDimension

comment:25 Changed 10 years ago by Alex Buts

(In [8141]) refs #1640; CPR works with Horace reader. further tests are needed

comment:26 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:27 Changed 10 years ago by Alex Buts

(In [8191]) refs #1640; fixed error left after switch to IMDDimensions

comment:28 Changed 10 years ago by Alex Buts

(In [8245]) refs #1640 DynamicRebinning got IDynamicRebinning interface. Minor bug fixes to horaceReader and other MDWorkspace parts

comment:29 Changed 10 years ago by Alex Buts

(In [8333]) refs #1640 various minor modifications to Dynamic rebinning and tests

comment:30 Changed 10 years ago by Alex Buts

(In [8335]) refs #1640 some nicenes for rebinning and tests; rebinning can have existing MDWorkspace as a target (overwriting it)

comment:31 Changed 10 years ago by Alex Buts

(In [8336]) refs #1640 more tests for CPR

comment:32 Changed 10 years ago by Alex Buts

(In [8651]) refs #1640 more tests for CPR The error in interpreting Horace data has been fixed

comment:33 Changed 10 years ago by Alex Buts

(In [8768]) refs #1640 more tests for CPR Enabling keep_pixels option in CPR

comment:34 Changed 10 years ago by Alex Buts

(In [8794]) refs #1640 more tests for CPR Enabling keep_pixels option in CPR -- intermediate check-out

comment:35 Changed 10 years ago by Alex Buts

(In [8797]) refs #1640 fixed some tests failing after changes in MDDataPointLocations search

comment:36 Changed 10 years ago by Alex Buts

(In [8805]) refs #1640 fixed some tests failing after changes

comment:37 Changed 10 years ago by Alex Buts

(In [8863]) refs #1640 simplified cprRebinningNx3 to achieve higher efficiency refs #1637 more tests for workspace components

comment:38 Changed 10 years ago by Alex Buts

(In [8884]) refs #1640 more tests (uncompleted)

comment:39 Changed 10 years ago by Alex Buts

(In [8899]) refs #1640 more tests for rebinning components

comment:40 Changed 10 years ago by Alex Buts

(In [8925]) refs #1640 more tests for rebinning components

comment:41 Changed 10 years ago by Alex Buts

(In [8932]) refs #1640 deleted outdated CPR components

comment:42 Changed 10 years ago by Alex Buts

(In [8943]) refs #1640 tests verified on huge files. More diagnostic messages and modifications to exclude old 4D format reader.

comment:43 Changed 10 years ago by Alex Buts

(In [9373]) refs #1640 rebinning, keep pixels in memory completed refs #1637 MDDataPoints manage pixels data placed in memory

comment:44 Changed 10 years ago by Alex Buts

  • Status changed from new to verify
  • Resolution set to worksforme

comment:45 Changed 10 years ago by Nick Draper

  • Resolution changed from worksforme to fixed

comment:46 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:47 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to closed

Centre piece rebinning verified works with multiple dimensions (tested with 4). Rebins correctly accross these dimensions allowing the user to specify n new uniformly spaced bins independently in each dimension. Specifying rotation matrix also result in correct reorientation for reciprocal space dimensions. Centre piece rebinning algorithm takes a MDGeometryDescription. Also, some cosmetic work to MantidPlot dialogs may be required, but this will occur under a differnt ticket.

comment:48 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2487

Note: See TracTickets for help on using tickets.