Ticket #1646 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Change getParameter to default to a recursive search

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description


Change History

comment:1 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Martyn Gigg

(In [6182]) Changed component parameter searches to be recursive by default. Re #1646

comment:3 Changed 10 years ago by Martyn Gigg

(In [6188]) Previous update to ParameterMap search fixed some behaviour when matching types that never actually worked properly. This resulted in test breakages. The problem was that fitting parameters were marked as type='fitting' in the definition file but called FitParamter in the ParameterMap. Searching for type 'fitting' then returned nothing. The type has been moved to from FitParameter->fitting so that ParameterMap::get/getRecursive now function correctly with the type argument. Re #1646

comment:4 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 10 years ago by Mathieu Doucet

(In [6374]) Move parameter since [6182] got rid of getNumberParameter() for the sample. Re #1646

comment:6 Changed 10 years ago by Mathieu Doucet

(In [6376]) Fixed test. Re #1646

comment:7 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:8 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

seems to work

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2493

Note: See TracTickets for help on using tickets.