Ticket #1693 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

MantidPlot: Ctrl+W shortcut to close a window doesn't work

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Iteration 26
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

You get the message: QAction::eventFilter: Ambiguous shortcut overload: Ctrl+W

I think this is a centrally-defined Qt shortcut. It does appear in qtiplot code but even after removing the instances there the error still remains.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Russell Taylor

comment:2 Changed 10 years ago by Russell Taylor

  • Status changed from assigned to accepted

comment:3 Changed 10 years ago by Russell Taylor

(In [8110]) Remove redundant shortcut. Re #1693.

comment:4 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

This applied to windows like tables, matrices, graphs, the Instrument window....

Previously, I was getting this error on: Linux (my build and rpm install), Windows (my builds) There did not appear to be a problem on: Windows (via installer), Mac

Now it's fine on my linux and also still works on the Mac. Didn't check anywhere else.

comment:5 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:6 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

on windows (built, not installed) pressing Ctrl+W doesn't show any errors. It doesn't do anything else, either. but looking at the change made that would seem to be what's intended.

comment:7 Changed 10 years ago by Russell Taylor

  • Status changed from closed to reopened
  • Resolution fixed deleted

No, that's not what's intended. Ctrl+W should close graph, table, etc windows but obviously no longer does on Windows. I think I'm going to put in an unpleasant WIN32 check.

comment:8 Changed 10 years ago by Russell Taylor

(In [8131]) Hack for close window shortcut to work on all platforms. Re #1693.

comment:9 Changed 10 years ago by Russell Taylor

  • Status changed from reopened to accepted

comment:10 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Works for me now on 64-bit Windows via Installer. Still works on self-built linux & Mac via installer. Don't completely know what's going on because before any changes I got an error on my windows build but none via installer. Still, it's the installers that matter.

comment:11 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying

comment:12 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

now works for me (win32) on built and installed versions (sorry for delay, took a long time to rebuild qtiplot for some reason)

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2540

Note: See TracTickets for help on using tickets.