Ticket #1706 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create algorithm for exponential helium tube efficiency

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

A new algorithm needs to be created for handling helium3 tube efficiency based on an exponential correction.

Change History

comment:1 Changed 10 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Michael Reuter

(In [6619]) Updating test instrument. This refs #1706.

comment:3 Changed 10 years ago by Michael Reuter

(In [6620]) Adding skeleton for efficiency correction algorithm. This refs #1706.

comment:4 Changed 10 years ago by Michael Reuter

(In [6621]) Removing print statement. This refs #1706.

comment:5 Changed 10 years ago by Michael Reuter

(In [6626]) Adding new algorithm to Visual Studio. This refs #1706.

comment:6 Changed 10 years ago by Michael Reuter

(In [6720]) Adding detector geometry calculations and further parameter retrieval. This refs #1706.

comment:7 Changed 10 years ago by Michael Reuter

(In [6724]) Adding actual efficiency calculation. This refs #1706.

comment:8 Changed 10 years ago by Michael Reuter

(In [6725]) Removing unneeded logging information and adding some constructor bits. This refs #1706.

comment:9 Changed 10 years ago by Michael Reuter

(In [6736]) Adding parameters to SNS DGS instruments. This refs #1706.

comment:10 Changed 10 years ago by Michael Reuter

(In [6740]) Small fixes to quiet warnings in debug build. This refs #1706.

comment:11 Changed 10 years ago by Michael Reuter

(In [6756]) Switching to simple method of getting parameters. This refs #1706.

comment:12 Changed 10 years ago by Michael Reuter

(In [6762]) Fixing typo in tag name. This refs #1706.

comment:13 Changed 10 years ago by Michael Reuter

(In [6769]) Adding more documentation. This refs #1706.

comment:14 Changed 10 years ago by Michael Reuter

(In [6770]) Fixing error in efficiency formula. This refs #1706.

comment:15 Changed 10 years ago by Michael Reuter

(In [6783]) Adding capability to override detector parameters. This refs #1706.

comment:16 Changed 10 years ago by Michael Reuter

(In [6790]) Doing progress reporting differently to avoid stuttering progress bar. This refs #1706.

comment:17 Changed 10 years ago by Michael Reuter

(In [6898]) Adding this point to logging calls. This refs #1706.

comment:18 Changed 10 years ago by Michael Reuter

(In [6904]) Checking event workspace test more properly. This refs #1706.

comment:19 Changed 10 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:20 Changed 10 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:21 Changed 10 years ago by Andrei Savici

  • Status changed from verifying to closed

Seems to be working. It is not idiot proof. You can put negative pressures, temperatures, or tube wall width greater than the diameter. Suggested quick fix: check if the exponent is greater than 0. Later, implement validators for arrays

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2554

Note: See TracTickets for help on using tickets.