Ticket #1818 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Crash when running PlotAsymmetryByLogValue

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

In MantidPlot.

Execute PlotAsymmetryByLogValue which put up a window. Select:

First run C:/Backup/Backup_folder1/work/code/Mantid/mantid/Test/Nexus/MUSR00015189.nxs

Last run C:/Backup/Backup_folder1/work/code/Mantid/mantid/Test/Nexus/MUSR00015199.nxs

Log value: run_number

Type: Integral

This causes MantidPlot to crash.

However if e.g. install of "run_number", "Field_Danfysik" is chosen as the log value then the algorithm runs fine.

Change History

comment:1 Changed 10 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Roman Tolchenov

(In [7170]) PlotAsymmetryByLogValue throws an exception if the log value doesn't exist or not of double type. re #1818

comment:3 Changed 10 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 10 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:5 Changed 10 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Still brakes when running the above described test.

comment:6 Changed 10 years ago by Anders Markvardsen

  • Status changed from reopened to assigned
  • Owner changed from Roman Tolchenov to Anders Markvardsen

comment:7 Changed 10 years ago by Anders Markvardsen

  • Status changed from assigned to accepted

comment:8 Changed 10 years ago by Anders Markvardsen

(In [7175]) Bug fix in PlotAsymmetryByLogValue. Added

if (!logp) {

throw std::invalid_argument("Log "+logName+" does not exist or not a double type");

}

at an addition place in PlotAsymmetryByLogValue.

re #1818

comment:9 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester changed from Anders Markvardsen to Michael Whitty

comment:11 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

Algorithm cancels with message: 

Error in execution of algorithm PlotAsymmetryByLogValue:
Log run_number does not exist or not a double type

Assuming this, rather than a crash, is the desired outcome.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2665

Note: See TracTickets for help on using tickets.