Ticket #1824 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Searching does not work if the facility is set to SNS in icat

Reported by: Russell Taylor Owned by: Jay Rainey
Priority: major Milestone: Release 3.1
Component: Framework Keywords: ICAT
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Nick Draper) (diff)

In this case you get an error message on login and the instrument combobox on the ICatSearch dialog is empty.

However, it is a valid use case that a user at the SNS might have done experiments at ISIS in the past and want to compare their data from there. There needs to be an easier way to make this work than at present (which is to go to the preferences and change your facility, and probably remember to change it back afterwards).

Also, where does this list of ISIS instruments come from? Stuart pointed out that one of them (HERBI) was a proposed TS2 instrument that didn't get funded.

Change History

comment:1 Changed 10 years ago by Nick Draper

Once we have an implementation for the SNS this becomes more of an issue.

At which point we need to add the facility drop down to the login box and use that.

The instruments list comes from the catalog implementation itself, so ICAT thinks HERBI exists even though we know better.

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:5 Changed 9 years ago by Nick Draper

  • Owner Sofia Antony deleted

Taken from Sofia Antony's list after she left

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:7 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anyone

comment:8 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:9 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:12 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:13 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:14 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:15 Changed 7 years ago by Nick Draper

  • Keywords ICAT added

comment:16 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:17 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:18 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:19 Changed 7 years ago by Nick Draper

  • Owner changed from Anyone to Jay Rainey
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.0

This should work once we have an ICAT 4 interface

comment:20 Changed 7 years ago by Jay Rainey

  • Milestone changed from Release 3.0 to Backlog

comment:21 Changed 7 years ago by Jay Rainey

  • Milestone changed from Backlog to Release 3.1

comment:22 Changed 7 years ago by Jay Rainey

  • Summary changed from ICat searching does not work if the facility is set to SNS to [ICAT] Searching does not work if the facility is set to SNS

comment:23 Changed 7 years ago by Arturs Bekasovs

While testing #8204 I've faced these problems as well. It is reproducible with any default facility apart from ISIS.

If you set it to e.g. SmuS, and try to search, it gives you results for LOQ. When you return to First Time Setup, your default facility and instrument are changed to ISIS -> LOQ.

comment:24 follow-up: ↓ 26 Changed 7 years ago by Jay Rainey

  • Milestone changed from Release 3.1 to Backlog

This has currently been fixed (in that you a drop-down list containing facilities is in the login dialog), but is not possible to fully verify (as only ISIS has an ICAT implementation).

Once I have implemented ICAT for SNS (in next release) this ticket can be verified.

comment:25 Changed 7 years ago by Jay Rainey

  • Summary changed from [ICAT] Searching does not work if the facility is set to SNS to Searching does not work if the facility is set to SNS in icat

comment:26 in reply to: ↑ 24 Changed 7 years ago by Jay Rainey

  • Status changed from new to verify
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.1

Replying to Jay Rainey:

Once I have implemented ICAT for SNS (in next release) this ticket can be verified.

Verification that it is working is evident in #8811 where users at SNS could log in using the log-in dialog box.

comment:27 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:28 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

The important point of this ticket - that you couldn't log into a facility's catalog if that facility was not your default one - is fixed by the addition of the drop-down box.

I can now log into and search the ISIS ICat when my facility is set to be the SNS. One minor point is that at the top of the search dialog it says "Currently logged into SNS" - that should be fixed, but it does correctly populate the instrument combobox.

I can also log into the SNS ICat. It seems like you can't do anything (the instrument combobox is empty), but that's outside the scope given for this ticket.

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2671

Note: See TracTickets for help on using tickets.