Ticket #1833 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Consolidate duplicated code in ConvertUnits

Reported by: Michael Reuter Owned by: Russell Taylor
Priority: minor Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

The functions convertViaTOF and convertViaEventsTOF have lots of similar code. Common functions should be created and the two functions should use the new common functions.

Change History

comment:1 Changed 10 years ago by Michael Reuter

  • Status changed from new to verify
  • Resolution set to fixed

(In [7189]) Updating to new SEQUOIA geometry. This fixes #1833.

comment:2 Changed 10 years ago by Michael Reuter

  • Status changed from verify to reopened
  • Resolution fixed deleted

The above change has nothing to do with this ticket.

comment:3 Changed 10 years ago by Nick Draper

  • Owner set to Russell Taylor
  • Status changed from reopened to assigned

comment:4 Changed 10 years ago by Russell Taylor

  • Status changed from assigned to accepted

comment:5 Changed 10 years ago by Russell Taylor

(In [7953]) Remove a memory leak in ConvertUnits for EventWorkspaces. Re #1973. Was supposed to fix crash if no instrument (Re #2002), but changes to geometry in connection with #2010 mean that the fix that worked yesterday doesn't work today. This is also leading up to a refactor to remove duplicated code - Re #1833.

comment:6 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:7 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:8 Changed 10 years ago by Russell Taylor

(In [10034]) Checkpointing ConvertUnits tidy up. Re #1833.

comment:9 Changed 10 years ago by Russell Taylor

(In [10036]) Fix Windows build. Re #1833.

comment:10 Changed 10 years ago by Russell Taylor

(In [10052]) ConvertUnits clean-up. No results should change! Also allow non-const dataX method on EventWorkspace as it's no more dangerous than a setX. Re #1833.

comment:11 Changed 10 years ago by Russell Taylor

(In [10082]) Tests for dataX on events. Re #1833.

comment:12 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

Everything seems OK.

comment:13 Changed 9 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:14 Changed 9 years ago by Michael Whitty

  • Status changed from verifying to closed

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2680

Note: See TracTickets for help on using tickets.