Ticket #1902 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create an ExtractMasking algorithm

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: critical Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

This should extract the masking from an algorithm into another WS.

It should output a Matrix WS with a single X bin, containing 0=masked, 1= not masked. The 0 spectra should also be marked as masked.

The workspace should be linked to the instrument so it can be visualised correctly.

Two maskedWS should be able to be added together using PLUS to accumulate the masking.

The maskedWS should work with MaskDetectors to apply the masking to other WS. #1901

Change History

comment:1 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Nick Draper

  • Owner changed from Martyn Gigg to Andrei Savici
  • Status changed from accepted to assigned

Let Martyn Gigg know when #1901 - #1903 are done

comment:3 Changed 10 years ago by Martyn Gigg

  • Owner changed from Andrei Savici to Martyn Gigg

comment:4 Changed 10 years ago by Martyn Gigg

I'm pretty much done with this. So I'm stealing it back.

comment:5 Changed 10 years ago by Martyn Gigg

  • Status changed from assigned to verify
  • Resolution set to fixed

(In [7503]) Add an ExtractMask algorithm to create a workspace that will be interpreted as one that simple shows which spectra are masked. The workspace created is compatible with the binary operations, in particular plus so that masking can be accumulated. Fixes #1902.

comment:6 Changed 10 years ago by Andrei Savici

If a spectrum is masked in one workspace it should be masked in any workspace that is the result of an addition. 0+1=1 when it should be 0 with the current notation

comment:7 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:8 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

works in [8123]. ExtractMasking algorithm brings out the masking, MaskDetectors will accept this as input and apply. Doing Plus on two Mask Workspaces keeps the masked spectra at zero, but the unmasked ones will go to 2, etc - but this doesn't seem to have any negative effect.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2749

Note: See TracTickets for help on using tickets.