Ticket #1910 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Eliminate use of PG3_732 files in unit tests

Reported by: Russell Taylor Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

This is part of the drive to reduce the size of our subversion repository and elimate the reading of data files in unit tests unless absolutely necessary.

PG3_732_neutron_event.dat is the biggest file used in unit tests!

Its use features in:

  • GhostCorrectionTest
  • DiffractionFocussing2Test (though in a currently disabled test)

Tests that have to load a file (i.e. those testing file loading algorithms) should switch to using a much smaller file. Others should create fictional data by using routines like WorkspaceCreationHelper.hh. If an algorithm under test requires the instrument geometry in any way then you may have to wait for completion of ticket #1899.

Change History

comment:1 Changed 10 years ago by Russell Taylor

(In [7422]) Remove commented-out reference to PG732 data file. Re #1910.

comment:2 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [7569]) Fixes #1910: PG3_732 data file cut down to a much smaller size for faster tests.

comment:4 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to reopened
  • Resolution fixed deleted

I need ticket #1899 to finish the test.

comment:5 Changed 10 years ago by Janik Zikovsky

  • Status changed from reopened to verify
  • Resolution set to fixed

(In [7581]) Fixes #1910. Removed references to PG3_732

comment:6 Changed 10 years ago by Janik Zikovsky

(In [7582]) Refs #1910. Removing PG3_732 data

comment:7 Changed 10 years ago by Russell Taylor

(In [7585]) Remove PG3...ghostmap test file. Re #1910

comment:8 Changed 10 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:9 Changed 10 years ago by Russell Taylor

  • Status changed from verifying to closed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2757

Note: See TracTickets for help on using tickets.