Ticket #1918 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Eliminate the use of HRP38692 in unit tests

Reported by: Russell Taylor Owned by: Karl Palmen
Priority: critical Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

This is part of the drive to reduce the size of our subversion repository and elimate the reading of data files in unit tests unless absolutely necessary.

Its use features in:

  • AlignDetectorsTest
  • DiffractionFocussingTest
  • DiffractionFocussing2Test
  • BackToBackExponentialTest
  • GaussianTest
  • UpdateInstrumentFromRawTest

Tests that have to load a file (i.e. those testing file loading algorithms) should switch to using a much smaller file. Others should create fictional data by using routines like WorkspaceCreationHelper.hh. If an algorithm under test requires the instrument geometry in any way then you may have to wait for completion of ticket #1899.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Anders Markvardsen
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Anders Markvardsen

(In [8100]) start on reduce exposure to hrp38692. re #1918

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:4 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:7 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:8 Changed 9 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Karl Palmen

comment:9 Changed 9 years ago by Russell Taylor

  • Priority changed from major to critical

It would be good to get this nailed down ahead of the move to git in ~2 weeks time.

comment:10 Changed 9 years ago by Anders Markvardsen

Estimated to take two man days

comment:11 Changed 9 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:12 Changed 9 years ago by Karl Palmen

After a talk with Anders Marksvarden, I removed the two tests of the look-up tables, because they use the file and are no longer necesary. I'm continuing work for the other tests to use a small selection of data from the file (HRP38692.raw) rather than the file itself.

comment:13 Changed 9 years ago by Karl Palmen

In [15282]:

Eliminated use of HRP38692.raw file, replacing some of its use by HRP38692a.nxs in unit testing for re #1918

comment:14 Changed 9 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to assigned

comment:16 Changed 9 years ago by Karl Palmen

In [15284]:

Modified Detector Focussing tests to explicitly load nexus file and expect one group rather than two groups also commented out a test in UpdateInstrumentFromFile. re #1918

comment:17 Changed 9 years ago by Karl Palmen

In [15293]:

In DataHandling UpdateInstrumentFromFileTest modify expected position of instrument. Re #1918

comment:18 Changed 9 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:19 Changed 9 years ago by Karl Palmen

  • Status changed from accepted to verify

comment:20 Changed 9 years ago by Mathieu Doucet

In [15340]:

Fix warnings. Re #1918

comment:21 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:22 Changed 9 years ago by Nick Draper

Verified that the file HRP38692.raw has been replaced by HRP38692a.nxs which is much smaller.

comment:23 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

comment:24 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2765

Note: See TracTickets for help on using tickets.