Ticket #1931 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Allow nested <rot> when <offsets spherical="delta" /> set in IDF

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: minor Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

When say

<location r="4.8" t="5.3" p="102.8" rot="-20.6" axis-x="0" axis-y="1" axis-z="0">

<rot val="102.8">

<rot val="50" axis-x="0" axis-y="1" axis-z="0" />

</rot>

</location>

don't ignore the nested <rot> when <offsets spherical="delta" /> set in IDF.

Change History

comment:1 Changed 10 years ago by Anders Markvardsen

(In [7523]) Code for Allow nested <rot> when <offsets spherical="delta" /> set in IDF. New collection of tests when spherical="delta" plus other additional tests. re #1931

comment:2 Changed 10 years ago by Anders Markvardsen

(In [7747]) Joe update of ENGINX IDF, where spherical=delta removed (made no difference to this IDF) and it has been made more compact by using <exclude>'s. re #1931

comment:3 Changed 10 years ago by Martyn Gigg

(In [7754]) Update a test after IDF file change. Re #1931

comment:4 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:5 Changed 10 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:6 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:8 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

In 1.1.9517 unit tests work and IDFs that have the <offsets spherical="delta" /> tag still load although none seem to use nested rot statements.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2778

Note: See TracTickets for help on using tickets.