Add definition of shape to intrument definition

[Nick Draper]

This needs to be done in partnership with Sri.

We need to add xml to the instrument files to define the shape of the base level types.

This needs to start with a discussion between Sri, Anders and Nick.

I suggest that we hide the fact that we are using infinite surfaces in our definitions, and provide user friendly tags for common objects.

 <Cylinder id="Bertie" radius=2 cap1="4,5,6" cap2="1,1,1"/>
 <Cuboid id="Harry" point1="0,0,0" point2="2,0,0" point3="2,2,2"/>
 <CSG algrebra="Bertie -Harry"/>

[Anders Markvardsen]

(In [1284]) Code added to specify geometry (for now sphere, infinite-plane and infinite-cylinder and any combination of these) in instrument definition file. Refs #194.

[Anders Markvardsen]

(In [1286]) This fix to (hopefully) get ShapeFactory to compile on Linux. Refs #194.

[Anders Markvardsen]

(In [1287]) Uummmm maybe this fix will fix the linux compiling issue with ShapeFactory. Refs #194.

[Anders Markvardsen]

(In [1327]) Modified so that an ID for shape may be any string and algebra string can be defined as e.g. "myCube + someSphere". Refs #194.

[Anders Markvardsen]

(In [1333]) Add support for <cylinder> element in instrument definition file. Refs #194.

[Anders Markvardsen]

(In [1338]) Add code to handle cuboid shape. For preliminary examples of how to use cuboid, cylinder and sphere elements see GEM_Definition.xml. Refs #194.

[Anders Markvardsen]

(In [1342]) Add approximately the right dimensions for the detector shapes for the GEM instrument. Assume xy-plane is the front of the detector. The origin is positioned in the middle of this plane and the z-axis points up from this plane. Refs #194.

[Nick Draper]

Now we just need to add support for rotation of the components through a facing tag. And allow boolean operations other than union.

[Anders Markvardsen]

(In [1384]) Added 'facing' element to instrument definition file. Facing here is defined as to be when the XY plane faces the 'facing object' with the Z-axis pointing in the direction away from the 'facing object'. An additional instrument definition file, to use for unit testing, has also been added. Refs #194.

[Anders Markvardsen]

(In [1397]) Roman fix of linking problem with Windows DS. Refs #194.

[Anders Markvardsen]

(In [1398]) Changed to allow algebra strings of the form "bob : soffie poul : (mysphere # myplane)", where the different names refers to different shapes in the instrument definition file. Refs #194.

[Anders Markvardsen]

(In [1409]) Now allow a facing-xyz attribute on each location element in instrument definition file. Refs #194.

[Anders Markvardsen]

(In [1410]) Updated doc which describes the geometry shapes supported in an instrument definition file and in general. Refs #194.

[Anders Markvardsen]

(In [1418]) Added facing as sub-element to location element in instrument def. file. Added support for cone and infinite-cone elements. Refs #194.

[Anders Markvardsen]

(In [1427]) Some further tests added to LoadInstrument, which further tests the facing facility. Refs #194.

[Anders Markvardsen]

(In [1428]) Support added for hexahedron shape and partially for torus to instrument def. file. Design document also updated. Refs #194.

[Stuart Campbell]

This ticket has been transferred to github issue ​1042