Ticket #1977 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Refactor MDWorkspace Constructional Logic

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Nick Draper) (diff)

Follow OO good citizenship.

  1. Enforce construction of MDWorkspace items in a valid state.
  2. Separate File loading from MDWorkspace.

Change History

comment:1 Changed 10 years ago by Owen Arnold

(In [7735]) refs #1977. Refactoring to pull constructional logic out of MDWorkspace objects. Primarily focused on MDGeometryBasis.

comment:2 Changed 10 years ago by Owen Arnold

(In [7736]) refs #1977. Refactoring so that MDImageData is created in one-shot with MDGeometry.

comment:3 Changed 10 years ago by Owen Arnold

(In [7745]) refs #1977. Revert so that setters are available on MDDimension.

comment:4 Changed 10 years ago by Owen Arnold

(In [7762]) refs #1977. Fix to make MDImageData sole owner of MDGeometry.

comment:5 Changed 10 years ago by Alex Buts

(In [7780]) refs #1977 MDImageData renamed to be MDImage and MD_Image_Data now is the underlying MD structure.

comment:6 Changed 10 years ago by Nick Draper

  • Description modified (diff)

comment:7 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:8 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:9 Changed 10 years ago by Owen Arnold

  • Status changed from new to accepted

Better. Further refactoring may be required in future.

comment:10 Changed 10 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 9 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:12 Changed 9 years ago by Russell Taylor

  • Status changed from verifying to closed

From a browse through the changes, the constructors do look stronger than they previously were. Good chance I'd agree with the statement 3 entries up.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2824

Note: See TracTickets for help on using tickets.