Ticket #1978 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Refactor MDWorkspace for Concept Reuse

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description (last modified by Nick Draper) (diff)

  1. Remove duplications
  2. Utilse Mantid and IMDWorkspace features wherever possible

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:4 Changed 10 years ago by Owen Arnold

  • Status changed from new to accepted

comment:5 Changed 10 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Better. Further refactoring may be required.

comment:6 Changed 9 years ago by Owen Arnold

A little hard to verify without some description or change-sets. Some of the changes made include:

  • Use of Mantid Geometry features such as quaternions and V3D within MDAlgorithms and MDDataObjects.
  • General coding against IMDWorkspace rather than MDWorkspace (see #2466 and #2767).

comment:7 Changed 9 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:8 Changed 9 years ago by Alex Buts

(In [11174]) refs #1978 MDWorkspace exposes const references or references unless it is absolutely necessary

comment:9 Changed 9 years ago by Alex Buts

(In [11185]) refs #1978 missing submission from last modification

comment:10 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to verify
  • Tester Alex Buts deleted

comment:11 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:12 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

Hard to test. But as Iteration 28 tickets need to be closed and VATES is not in the build kit I am closing this ticket.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2825

Note: See TracTickets for help on using tickets.