Ticket #2002 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

ConvertUnits crashes mantid

Reported by: Peter Peterson Owned by: Russell Taylor
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

If ConvertUnits is run on a workspace that doesn't have an instrument mantidplot crashes. Check that the instrument returned actually has a source object before de-referencing it. This is similar to the changes made in AlignDetectors with #1947.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Russell Taylor
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Russell Taylor

  • Status changed from assigned to accepted

comment:3 Changed 10 years ago by Russell Taylor

(In [7953]) Remove a memory leak in ConvertUnits for EventWorkspaces. Re #1973. Was supposed to fix crash if no instrument (Re #2002), but changes to geometry in connection with #2010 mean that the fix that worked yesterday doesn't work today. This is also leading up to a refactor to remove duplicated code - Re #1833.

comment:4 Changed 10 years ago by Russell Taylor

(In [7970]) Fix for ConvertUnits crash if no instrument - ensure getSource & getSample always return null pointers if not set. Re #2002.

comment:5 Changed 10 years ago by Russell Taylor

(In [7978]) Fix things. Re #2002.

comment:6 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:8 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

now exits algorithm and gives a sensible error message rather than crashing the program.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2849

Note: See TracTickets for help on using tickets.