Ticket #2012 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Convert a normal EventWorkspace into a MDWorkspace.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 28
Component: Mantid Keywords:
Cc: saviciat@… Blocked By: #2016
Blocking: Tester: Roman Tolchenov

Description

  • Convert from pixels with counts per TOF to Qx, Qy, Qz, and (E) in the lab reference frame.
  • Allow to take into account goniometer rotation, but maybe keep an empty rotation matrix to start.
  • Do we keep individual events in the case of EventWorkspaces?

Things to think about:

  • Memory usage, saving to disk (kind of like a ManagedWorkspace2D).

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Milestone changed from Iteration 26 to Iteration 27

comment:2 Changed 10 years ago by Janik Zikovsky

  • Blocking 2016 added

comment:3 Changed 10 years ago by Janik Zikovsky

  • Blocking 2016 removed
  • Blocked By 2016 added

comment:4 Changed 10 years ago by Janik Zikovsky

comment:5 Changed 10 years ago by Janik Zikovsky

comment:6 Changed 10 years ago by Janik Zikovsky

  • Milestone changed from Iteration 27 to Iteration 28

comment:7 Changed 10 years ago by Andrei Savici

  • Cc saviciat@… added

comment:8 Changed 10 years ago by Andrei Savici

No rotation matrix is necessary. It should be taken care of by the UB matrix

comment:9 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:10 Changed 10 years ago by Janik Zikovsky

(In [9749]) Refs #2012: Stub for an algo to create a reciprocal space MDEW.

comment:11 Changed 10 years ago by Janik Zikovsky

(In [10008]) Refs #2012: MDEvents target; Refs #2638: Use the same fix for Multiply as for divide.

comment:12 Changed 10 years ago by Janik Zikovsky

(In [10070]) Refs #2012: More code for adding events into gridded boxes.

comment:13 Changed 10 years ago by Janik Zikovsky

(In [10088]) Refs #2012: code to add vectors of MDEvents to a MDGridBox, with tasks and recursive grid splitting.

comment:14 Changed 10 years ago by Janik Zikovsky

(In [10089]) Refs #2012: Removed HDF dependency from MDEvents cmake.

comment:15 Changed 10 years ago by Janik Zikovsky

(In [10090]) Refs #2012: Removed includes I was not using in tests.

comment:16 Changed 10 years ago by Janik Zikovsky

(In [10095]) Refs #2012: Checkpointing MDGridBox.

comment:17 Changed 10 years ago by Janik Zikovsky

(In [10098]) Refs #2012: Fix windows openmp test build.

comment:18 Changed 10 years ago by Janik Zikovsky

(In [10111]) Refs #2666 and Refs #2012: Progress reporting in tests for MDGrid

comment:19 Changed 10 years ago by Janik Zikovsky

(In [10113]) Refs #2012: Double speed of gridding MDEvents by parallelizing the MDBox splitting portion.

comment:20 Changed 10 years ago by Janik Zikovsky

(In [10117]) Refs #2012: Created a small instrument to test diffraction code (MINITOPAZ).

comment:21 Changed 10 years ago by Janik Zikovsky

(In [10118]) Refs #2012: Fix test.

comment:22 Changed 10 years ago by Janik Zikovsky

(In [10127]) Refs #2012: Fix Jenkins windows build I hope.

comment:23 Changed 10 years ago by Janik Zikovsky

(In [10136]) Refs #2012: Checkpointing code that is doing a good part of the work of eventworkspace->q-space conversion.

comment:24 Changed 10 years ago by Janik Zikovsky

(In [10142]) Refs #2012: Moved a function from MDGridBox to MDEventWorkspace, and test too.

comment:25 Changed 10 years ago by Janik Zikovsky

(In [10147]) Refs #2012: Added a method to get EventList events vector using an overloaded function. This will allow easier templatization outside of EventList.

comment:26 Changed 10 years ago by Janik Zikovsky

(In [10148]) Refs #2012: Templated the method for converting event lists, so now it handles all types. Added # of points in GUI.

comment:27 Changed 10 years ago by Janik Zikovsky

(In [10149]) Refs #2012: Fix windows test build.

comment:28 Changed 10 years ago by Janik Zikovsky

(In [10166]) Refs #2012: Removed non-portable test line.

comment:29 Changed 10 years ago by Janik Zikovsky

(In [10167]) Refs #2012: MakeDiffractionMDEventWorkspace progress.

comment:30 Changed 10 years ago by Janik Zikovsky

(In [10170]) Refs #2012: Method for counting the number of MDBoxes (recursively).

comment:31 Changed 10 years ago by Janik Zikovsky

(In [10173]) Refs #2012: MDBoxes get split while adding events.

comment:32 Changed 10 years ago by Janik Zikovsky

(In [10178]) Refs #2012: Progress reporting has a doReport() method to change the message shown, even if the percentage is not increasing.

comment:33 Changed 10 years ago by Janik Zikovsky

(In [10179]) Refs #2012: Show History menu for MDEventWorkspaces.

comment:34 Changed 10 years ago by Janik Zikovsky

(In [10195]) Refs #2012: Memory gets cleared during creation of MDEventWorkspace. Added a MemoryManager call that tracks free memory and clears it only after accumulating enough.

comment:35 Changed 10 years ago by Janik Zikovsky

(In [10199]) Refs #2012: Fixed memory leak.

comment:36 Changed 10 years ago by Janik Zikovsky

(In [10211]) Refs #2012: Test is failing sometimes; disabling until I find out why.

comment:37 Changed 10 years ago by Janik Zikovsky

(In [10238]) Refs #2012: Accidentally re-enabled this test.

comment:38 Changed 10 years ago by Janik Zikovsky

(In [10271]) Refs #2012: Try test on other platforms.

comment:39 Changed 10 years ago by Janik Zikovsky

(In [10272]) Refs #2012: Re-disabling test that fails.

comment:40 Changed 10 years ago by Janik Zikovsky

(In [10348]) Refs #2012: Re-enabling test with more output to try to find why it fails on some places.

comment:41 Changed 10 years ago by Janik Zikovsky

(In [10349]) Refs #2012.

comment:42 Changed 10 years ago by Janik Zikovsky

(In [10359]) Refs #2012: test.

comment:43 Changed 10 years ago by Janik Zikovsky

(In [10368]) Refs #2012: More output in test to try to find the bug.

comment:44 Changed 10 years ago by Stuart Campbell

(In [10369]) Added MINITOPAZ to TEST facility. refs #2012

comment:45 Changed 10 years ago by Stuart Campbell

(In [10370]) Fix test. refs #2012

comment:46 Changed 10 years ago by Janik Zikovsky

(In [10513]) Refs #2012: MakeDiffractionMDEventWorkspace can add to an existing MDEventWorkspace

comment:47 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Will close this ticket as it seems working fine (need Viz to confirm). See #2784 for further work on this algo.

comment:48 Changed 9 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:49 Changed 9 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The algorithm crashes both in the test and when run in MantidPlot. It seems that it breaks at line 293 in BoxController.h (the index to m_maxNumMDBoxes is out of range). It also seems that the algorithm works only with events but not with Workspace2D.

comment:50 Changed 9 years ago by Janik Zikovsky

  • Milestone changed from Iteration 28 to Iteration 29

comment:51 Changed 9 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:52 Changed 9 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Summary changed from Convert a normal Workspace (event or 2D) into a MDWorkspace. to Convert a normal EventWorkspace into a MDWorkspace.

The bug described should be fixed in the branch of Iteration29 (see #2762).

As for the Workspace2D, I do not currently have a plan to implement converting Workspace2D to EventWorkspace; if so, it would be the subject of a different ticket.

comment:53 Changed 9 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Milestone changed from Iteration 29 to Iteration 28

comment:54 Changed 9 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:55 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2859

Note: See TracTickets for help on using tickets.