Add unit test for FlatBackground for when we return the background

[Stuart Campbell]

The current unit tests only test the case of returning the corrected input data and not when we return the actual background.

[Nick Draper]

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

[Nick Draper]

Bulk move of tickets at the end of iteration 27

[Nick Draper]

Bulk move of tickets at the end of iteration 28

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Nick Draper]

Moved to iteration 33 at iteration 32 code freeze

[Nick Draper]

Moved at end of release 2.1

[Nick Draper]

http://www.mantidproject.org/Release_Notes_2_2_Full_List

[Nick Draper]

Moved to release 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Keith Brown]

FlatBackground is now deprecated. The applicable unit test will be added to the current method if it does not contain a test for it already.

Current algorithm is called CalculateFlatBackground

[Keith Brown]

Added WithReturnBackground tests and refactored tests in general

testExec and testMeanFirst now have WithReturnBackground versions.

Code has been refactored so that the algorithm executing is now in a separate method that sets the properties accordingly for that test.

A lot of TS_ASSERT_EQUALS tests have been chaged to TS_ASSERT_DELTA tests.

Refs #2057

Changeset: 7c57db5edd78ee4f7353d1a5336f3c0574cad3d9

[Martyn Gigg]

Please fix this GCC compiler warning and then re-close:

CalculateFlatBackgroundTest.h: In member function ‘void CalculateFlatBackgroundTest::testMeanFirstWithReturnBackground()’: CalculateFlatBackgroundTest.h:178: warning: unused variable ‘correct’

[Keith Brown]

Fixed GCC compiler warning

Fixed a compiler warning by removing an unused variable

Refs #2057

Changeset: 64c0c6a93c202f96f4d845e3544619f4c8847eb6

[Gesner Passos]

I do not quite agree with the way the tests were changed. By having a function 'runCalculateFlatBackground(int functindex)' I understand that you avoid repeating code, what is good, but you make the understanding of the test not straight forward. I consider that being clear in the tests is better than being efficient (they are executed only by us, not by users). But this is only my opinion. So I will just move back to the pool. Maybe, another developer will have another opinion.

[Keith Brown]

I did originally have it clear like that, but Martyn suggested refactoring to save repeated code, so i did. I do think the result was messy too, but it was the best i could come up with having been told to group similar code and it does show each test's differences well.

[Anders Markvardsen]

To clarify tests a bit more add brief comment to what CalculateFlatBackgroundTest does and move up the method runCalculateFlatBackground even though it is private. Someone reading the test will then briefly see the headlines of this class and method before the content of the different tests

[Keith Brown]

Moved some code and improved commenting

The method that runs the algorithm in different ways has been moved to the top.

A comment breifly mentioning what the test does has been added.

Refs #2057

Changeset: a1178353f849528281907794b779cbb1f4f88636

[Anders Markvardsen]

Merge remote-tracking branch 'origin/feature/2057_FlatBackground_return_test'

[Anders Markvardsen]

requested functionality has been added

[Stuart Campbell]

This ticket has been transferred to github issue ​2904