Improve BASIS instrument geometry

[Stuart Campbell]

The current BASIS geometry file is very basic. It needs a number of improvements, such as unique pixels shapes, Ef per pixel.

There also needs to be a way to specify detectors that don't have a neutronic position (i.e. detectors that the neutron cannot reach directly)

[Peter Peterson]

When running LoadEmpyInstrument on the file there is also a load of warnings.

Algorithm: LoadEmptyInstrument v1
Parameters:
  Name: Filename, Value: /home/pf9/code/mantid/trunk/Test/Instrument/BASIS_Definition.xml, Default?: No, Direction: Input
  Name: OutputWorkspace, Value: BASISgeom, Default?: No, Direction: Output
  Name: DetectorValue, Value: 1, Default?: Yes, Direction: Input
  Name: MonitorValue, Value: 2, Default?: Yes, Direction: Input
Not successful in adding Detector 0x7f108efb2238 to _detectorCache.
Not successful in adding Detector 0x7f108efb2238 to _detectorCache.
Not successful in adding Detector 0x7f108efb2238 to _detectorCache.
Not successful in adding Detector 0x7f108efb2238 to _detectorCache.
Not successful in adding Detector 0x7f108efb2238 to _detectorCache.
Not successful in adding Detector 0x7f108efb2238 to _detectorCache.
Not successful in adding Detector 0x7f108efb2238 to _detectorCache.
...
Cache not available at /home/pf9/code/mantid/trunk/Test/Instrument/BASIS_Definition.vtp
Trying fallback /tmp/BASIS_Definition.vtp
Geometry cache is not available
Creating cache in /home/pf9/code/mantid/trunk/Test/Instrument/BASIS_Definition.vtp
 add Data Object 'BASIS_Definition.xml2010-12-15 14:57:40.536439' successful
Invalid argument to LoadParameter sub-algorithm
Invalid value for property Filename (string) "/home/pf9/code/mantid/trunk/Test/Instrument//BASIS_Parameters.xml": File "BASIS_Parameters.xml" not found
 add Data Object 'BASISgeom' successful
LoadEmptyInstrument successful, Duration 2.67 seconds

[Nick Draper]

Bulk move of tickets at the end of iteration 28

[Janik Zikovsky]

(In [12082]) Fixes #3075: SaveIsaw peaks adds the detector info.

[Janik Zikovsky]

Sorry, this last commit was supposed to go to #3075.

[Stuart Campbell]

In [13437]:

Added Ef to pixels. refs #2075

[Stuart Campbell]

In [13441]:

Initial BASIS parameter file. refs #2075

[Stuart Campbell]

In [13442]:

Modified from date to be in the past. refs #2075

[Stuart Campbell]

In [13503]:

Removed parameters used in indirect CTE gui as we are not using it at the moment and it only generates errors. refs #2075

[Stuart Campbell]

In [14347]:

Changed pixel size to be the real physical size. refs #2075

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Stuart Campbell]

In [14853]:

Initial version of SI111 parameter file as needed by CTE interface. refs #2075

[Stuart Campbell]

In [14854]:

Update parameter file as needed by CTE interface - still not 100% happy yet though. refs #2075

[Stuart Campbell]

Added all pixels. refs #2075

Had to add the non-existent pixels into the IDF as the NeXus file doesn't differentiate between pixels that are there or not.

Changeset: b449786db3b4354aa361841322751d29f6937365

[Stuart Campbell]

Added a global fallback Ef for each bank. refs #2075

The value used is the average value over all pixels.

Changeset: 6a9ddcc0dab7f2742468cacf9fcaccf2455a48de

[Nick Draper]

Moved to iteration 33 at iteration 32 code freeze

[Stuart Campbell]

Added BASIS North banks. refs #2075

Valid for runs 16694 onwards.

Changeset: b2ef82c4a737123c59901c4c7af49a9ddbf6bc77

[Stuart Campbell]

Added correct valid-to date. refs #2075

Changeset: b676e065852c75eb071ac14802e1c12ef0125e4f

[Stuart Campbell]

This geometry file is very slow to load and needs neutronic/physical positions adding (see #3884).

But that can be done in the next iteration.

[Michael Reuter]

This looks fine to me.

[Stuart Campbell]

This ticket has been transferred to github issue ​2922