Ticket #2076 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

LoadGSS with not load files save with SLOG format.

Reported by: Stuart Campbell Owned by: Wenduo Zhou
Priority: minor Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Peter, Peterson, A.J.Markvardsen@… Blocked By:
Blocking: Tester: Peter Peterson

Description

If you save a file using SaveGSS using the SLOG format, then LoadGSS will not load it correctly.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner changed from Nick Draper to Russell Taylor
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:3 Changed 10 years ago by Nick Draper

  • Owner changed from Russell Taylor to Stuart Campbell

comment:4 Changed 10 years ago by Stuart Campbell

  • Owner changed from Stuart Campbell to Peter Peterson

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:6 Changed 9 years ago by Peter Peterson

  • Owner changed from Peter Peterson to Wenduo Zhou

comment:7 Changed 9 years ago by Wenduo Zhou

  • Status changed from assigned to verify
  • Resolution set to fixed

(In [11491]) Changed LoadGSS.cpp to load GSAS file in SLOG format. Fixes #2076

comment:8 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:9 Changed 9 years ago by Anders Markvardsen

  • Cc Peter, Peterson, A.J.Markvardsen@… added; Peter Peterson removed

Hi,

Have tested this ticket and get the following results I didn't expect:

1) Saved AutoTestData/HRP37125.raw used SaveGSS with SplitFiles=False, Append not ticketed and Format=SLOG. Loaded the saved file into a new workspace. Original workspace contains 2890 histograms, HOWEVER reloaded workspace only contains 1146 histograms. Also the title has changed from "Quiet count 2890 spectra" to "Sample Run: 37125 Vanadium Run...", which may be intensional but just looks a bit surprising

2) When repeating the above for "AutoTestData/focussedGEM38370_TOF.nxs" this time the number of histogram is the same before and after saving/loading. However the title has still changed? Is this intensional?

Also note wiki page http://www.mantidproject.org/SaveGSS contain no information about the 'Format' parameter.

comment:10 Changed 9 years ago by Wenduo Zhou

  • Status changed from verifying to verify

(In [12914]) Add a validator in SaveGSS() to throw exceptin if Workspace has more than 99 spectra. Fixes #2076.

comment:11 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester changed from Anders Markvardsen to Peter Peterson

comment:12 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to closed

Ran SNSPowderReduction on PG3_2982 and read the result back in. The data matched exactly.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2923

Note: See TracTickets for help on using tickets.