Ticket #2179 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create atom facility

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Put the fancy layer on top of the NeutronAtom which contains the information common to atoms. This includes a list of isotopes, natural abundencies, mass, density, and number density. Similar to the NeutronAtom the atoms themselves should have a factory to create them and be immutable.

Much of the underlying typing of numbers have been done in the DANSE periodictable python package available via easy_install. Use that as a basis for numbers as possible by writing a python script to generate the values using it.

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Status changed from new to accepted
  • Owner set to Peter Peterson

comment:2 Changed 10 years ago by Peter Peterson

(In [8349]) Changed the type of z and a to allow for more isotopes as required by the Atom struct. Refs #2179.

comment:3 Changed 10 years ago by Peter Peterson

(In [8350]) Added ==, !=, and checked that the search returns what the user wanted. Refs #2179.

comment:4 Changed 10 years ago by Peter Peterson

(In [8351]) Adding a python code to generate the values for Atoms.cpp. Refs #2179.

comment:5 Changed 10 years ago by Peter Peterson

During the course of this ticket #2182 was created for adding information to the NeutronAtom.

comment:6 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8352]) Adding an atom class to the framework. Fixes #2179.

comment:7 Changed 10 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

Builds are broken.

comment:8 Changed 10 years ago by Peter Peterson

(In [8353]) Added operator to get ostream support. Refs #2179.

comment:9 Changed 10 years ago by Peter Peterson

(In [8354]) Refs #2179.

comment:10 Changed 10 years ago by Peter Peterson

(In [8355]) Refs #2179.

comment:11 Changed 10 years ago by Peter Peterson

(In [8356]) Refs #2179.

comment:12 Changed 10 years ago by Peter Peterson

(In [8357]) Refs #2179.

comment:13 Changed 10 years ago by Peter Peterson

(In [8361]) Made the NeutronAtom a reference and all members const. Also commented out more offending tests (for now). Refs #2179.

comment:14 Changed 10 years ago by Peter Peterson

(In [8362]) Removing Atoms with z>96. Refs #2179.

comment:15 Changed 10 years ago by Peter Peterson

  • Status changed from reopened to accepted

comment:16 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

The last commit fixed this.

comment:17 Changed 10 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:18 Changed 10 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3026

Note: See TracTickets for help on using tickets.