Ticket #2180 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Make the case of NeXus consistent

Reported by: Stuart Campbell Owned by: Stuart Campbell
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By: #1787, #3295
Blocking: Tester: Michael Reuter

Description

The case of the word NeXus is not consistent throughout the project. It should be.

Change History

comment:1 Changed 10 years ago by Stuart Campbell

  • Summary changed from Make the use of NeXus consistent to Make the case of NeXus consistent

comment:2 Changed 10 years ago by Stuart Campbell

(In [8577]) Made test filename match classname. refs #2172 & #1881 & #2180

comment:3 Changed 10 years ago by Stuart Campbell

  • Blocked By 1787 added
  • Milestone changed from Iteration 27 to Iteration 28

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:5 Changed 9 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:6 Changed 9 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

All the algorithms (except for the *PreNeXus* ones) seem to have already been done.

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to reopened
  • Resolution fixed deleted

These files/algorithms has the NeXus case as opposed to Nexus (which dominates in #): 

ack-grep -g NeXus:


Framework/DataHandling/LoadPreNeXusMonitorsTest.cpp
Framework/DataHandling/src/LoadEventPreNeXus.cpp
Framework/DataHandling/src/LoadNeXus.cpp
Framework/DataHandling/src/SaveNeXus.cpp
Framework/DataHandling/src/SaveISISNeXus.cpp
Framework/DataHandling/src/LoadPreNeXusMonitors.cpp
Framework/DataHandling/test/LoadNeXusTest.h
Framework/DataHandling/test/LoadPreNeXusMonitorsTest.h
Framework/DataHandling/test/LoadEventPreNeXusTest.h
Framework/DataHandling/test/SaveNeXusTest.h
Framework/DataHandling/SaveNeXusTest.cpp
Framework/DataHandling/LoadEventPreNeXusTest.cpp
Framework/DataHandling/LoadNeXusTest.cpp
Framework/DataHandling/inc/MantidDataHandling/SaveISISNeXus.h
Framework/DataHandling/inc/MantidDataHandling/LoadPreNeXusMonitors.h
Framework/DataHandling/inc/MantidDataHandling/LoadNeXus.h
Framework/DataHandling/inc/MantidDataHandling/LoadEventPreNeXus.h
Framework/DataHandling/inc/MantidDataHandling/SaveNeXus.h

But does anyone care enough to rename them? :)

comment:9 Changed 9 years ago by Stuart Campbell

(In [12860]) Renaming LoadNeXus->LoadNexus. refs #2180

comment:10 Changed 9 years ago by Stuart Campbell

(In [12861]) refs #2180

comment:11 Changed 9 years ago by Stuart Campbell

(In [12862]) refs #2180

comment:12 Changed 9 years ago by Stuart Campbell

(In [12863]) Renaming LoadNeXus() -> LoadNexus(). refs #2180

comment:13 Changed 9 years ago by Stuart Campbell

(In [12864]) Update references to LoadNeXus.h refs #2180

comment:14 Changed 9 years ago by Stuart Campbell

(In [12865]) Update references to LoadNeXus.h refs #2180

comment:15 Changed 9 years ago by Stuart Campbell

(In [12866]) Update references to LoadNeXus.h refs #2180

comment:16 Changed 9 years ago by Stuart Campbell

(In [12875]) Renamed SaveNeXus to SaveNexus. refs #2180

comment:17 Changed 9 years ago by Stuart Campbell

(In [12876]) renamed SaveISISNeXus to SaveISISNexus. refs #2180

comment:18 Changed 9 years ago by Stuart Campbell

  • Status changed from reopened to accepted

comment:19 Changed 9 years ago by Stuart Campbell

(In [12910]) Renamed LoadEventPreNeXus -> LoadEventPreNexus. refs #2180

comment:20 Changed 9 years ago by Stuart Campbell

(In [12911]) Renamed LoadPreNeXusMonitors -> LoadPreNexusMonitors. refs #2180

comment:21 Changed 9 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

All done in DataHandling. There are a few cases in the NeXus namespace - but these aren't algorithms.

comment:22 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester changed from Janik Zikovsky to Michael Reuter

comment:23 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

This looks good as FindSNSNeXus.py is going to be deprecated.

comment:24 Changed 9 years ago by Stuart Campbell

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:25 Changed 9 years ago by Stuart Campbell

(In [12921]) Forgot to add the aliases. refs #2180

comment:26 Changed 9 years ago by Stuart Campbell

(In [12922]) Updated test. refs #2180

comment:27 Changed 9 years ago by Stuart Campbell

  • Status changed from reopened to accepted

comment:28 Changed 9 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:29 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:30 Changed 9 years ago by Michael Reuter

  • Blocked By 3295 added

This convert to energy transfer GUI no longer works since the alias are broken. Adding a blocked by ticket.

comment:31 Changed 9 years ago by Stuart Campbell

(In [12930]) Update our scripts to use the correct name for LoadEventPreNexus(). refs #2180

comment:32 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

Everything is now case consistent. Whew!

comment:33 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3027

Note: See TracTickets for help on using tickets.