Ticket #2303 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

MUON: Extend MuonAnalysis to include next and previous options

Reported by: Nick Draper Owned by: Robert Whitley
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Nick Draper) (diff)

These should be optional and will only be used in certain UIs the default will be not to include them.

When append is false

 Next simply add one to the run number of the current file. Such that
 EMU11 -> EMU12

When append is true

 Next leaves the current file in the run box and add another one starting a range, such that
 EMU11 -> EMU11-12
 EMU11-12 -> EMU 11-13

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:4 Changed 9 years ago by Anders Markvardsen

  • Status changed from new to accepted
  • Summary changed from Extend MWrunfiles to include next and append options to MUON: Extend MWrunfiles to include next and append options

comment:5 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to assigned
  • Owner changed from Anders Markvardsen to Robert Whitley

Initially add 'Next' and 'Previous' optional buttons.

Then add optional 'Append' tickbox to the MWRunfiles widget

comment:6 Changed 9 years ago by Robert Whitley

In [14011]:

Refs #2303. Previous and next buttons have been implemented and work. Append is currently greyed out because the functionality with it set to true isn't quite working when saving. Decided to implement this in muon analysis because it might make the browser plugin messy by having too many options. May want to be moved in the future.

comment:7 Changed 9 years ago by Robert Whitley

  • Status changed from assigned to accepted

comment:8 Changed 9 years ago by Robert Whitley

In [14011]:

There is some code that applies to the ticket #3226. I have added a new data analysis tab which is an edited version of the fitPropertyBrowser plugin in QtDesigner. I've also written some code to make sure the user can't remove the widget from the tab.

comment:9 Changed 9 years ago by Robert Whitley

  • Summary changed from MUON: Extend MWrunfiles to include next and append options to MUON: Extend MuonAnalysis to include next and previous options

comment:10 Changed 9 years ago by Robert Whitley

New ticket #3728 created to improve functionality by including an appending option.

comment:11 Changed 9 years ago by Robert Whitley

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 9 years ago by Robert Whitley

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:13 Changed 9 years ago by Robert Whitley

In [14777]:

Refs #2303. Fixed occasional crashes when trying to load next and previous files from a different file location

comment:14 Changed 9 years ago by Robert Whitley

  • Status changed from reopened to accepted

Make sure you have updated version of Mantid to test this functionality.

comment:15 Changed 9 years ago by Robert Whitley

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:17 follow-up: ↓ 18 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This morning did svn update + rebuild Mantid.

Bug previously reported still persist. Re reproduce follow these steps:

  1. Open MuonAnalysis
  2. Browse to mantid/Test/Nexus and pick say MUSR00015190.nxs, which loads fine
  3. Click the next (arrow) button and filename is changed to Backup_folder0000000000000000000000000000000000000000000000001.nxs

comment:18 in reply to: ↑ 17 Changed 9 years ago by Robert Whitley

Replying to Anders Markvardsen:

This morning did svn update + rebuild Mantid.

Bug previously reported still persist. Re reproduce follow these steps:

  1. Open MuonAnalysis
  2. Browse to mantid/Test/Nexus and pick say MUSR00015190.nxs, which loads fine
  3. Click the next (arrow) button and filename is changed to Backup_folder0000000000000000000000000000000000000000000000001.nxs

I can't seem to reproduce this bug, it is working on my computer running Windows 7. I will have to look at the error on your computer when you are next in the office.

comment:19 Changed 9 years ago by Anders Markvardsen

We just noticed works from path:

C:\MANTID\Test

but not:

C:\Backup\Backup_folder1\work\code\Mantid\mantid\Test\Nexus

comment:20 Changed 9 years ago by Robert Whitley

In [14810]:

Refs #2303. Fixed a crash when trying to load next and previous files from a directory containing a number. For example C:\Backup\Backup_folder1

comment:21 Changed 9 years ago by Robert Whitley

  • Status changed from reopened to accepted

comment:22 Changed 9 years ago by Robert Whitley

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:23 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying

comment:24 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Works now well

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3150

Note: See TracTickets for help on using tickets.