Ticket #2320 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Make Rietveld reduction work with NOMAD

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Do what needs to be done to get NOMAD up and running doing Rietveld reduction.

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Status changed from new to accepted
  • Owner set to Peter Peterson

comment:2 Changed 10 years ago by Peter Peterson

(In [9003]) Adding NOMAD to the ugly hack. Refs #2320.

comment:3 Changed 10 years ago by Peter Peterson

(In [9004]) Adding parameter to force the output workspace to be a histogram. Refs #2320.

comment:4 Changed 10 years ago by Peter Peterson

(In [9119]) Moved a static member to be an instance member which fixes some new problems in SNSPowderReduction. Refs #2320.

comment:5 Changed 10 years ago by Peter Peterson

(In [9488]) Added more to the list on introspection. Refs #2320.

comment:6 Changed 10 years ago by Peter Peterson

(In [9489]) Checkpointing for the night so this will get into the build. Refs #2320.

comment:7 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:8 Changed 10 years ago by Peter Peterson

(In [9499]) Refs #2320.

comment:9 Changed 10 years ago by Peter Peterson

(In [9513]) Refs #2320

comment:10 Changed 10 years ago by Peter Peterson

(In [9515]) Try just using the data paths beforetrying findnexus. Refs #2320.

comment:11 Changed 10 years ago by Peter Peterson

(In [9520]) Fixing small bug. Refs #2320.

comment:12 Changed 10 years ago by Peter Peterson

(In [9549]) Adding another compressevents call after subtraction to shrink the data. Refs #2320.

comment:13 Changed 10 years ago by Peter Peterson

(In [9696]) Added wallclock filtering. Refs #2320.

comment:14 Changed 10 years ago by Peter Peterson

(In [9703]) Adding ability to sum runs. Refs #2320.

comment:15 Changed 10 years ago by Peter Peterson

(In [9823]) More generic fixes for NOMAD. Added ability to call load with compression on. Refs #2320.

comment:16 Changed 10 years ago by Vickie Lynch

(In [9829]) Refs #2320 Add masking to MultipleScattering and SaveGSS

comment:17 Changed 10 years ago by Vickie Lynch

(In [9830]) Refs #2320 Removed my changes for masking

comment:18 Changed 10 years ago by Vickie Lynch

(In [9831]) Refs #2320 Add masking to MultipleScattering and SaveGSS. Test of dataset without instrument OK now.

comment:19 Changed 10 years ago by Vickie Lynch

(In [9832]) Refs #2320 Moved some instrument function calls outside spectra loop in SaveGSS

comment:20 Changed 10 years ago by Vickie Lynch

(In [9837]) Refs #2320 Added masking to execEvent in DiffractionFocussing in same way as spectra not in a group

comment:21 Changed 10 years ago by Vickie Lynch

(In [9841]) Refs #2320 Fixed the flips for NOMAD instrument definition; added groups

comment:22 Changed 10 years ago by Peter Peterson

(In [9884]) Put compression tolerance in head of file. Added an additional compression after DiffractionFocussing to make later steps faster. Refs #2320.

comment:23 Changed 10 years ago by Peter Peterson

(In [10200]) Release memory during the algorithm so you don't fall into swap. Refs #2320.

comment:24 Changed 10 years ago by Peter Peterson

(In [10201]) Change minimum bank number if the user did not supply a characterizations file. Refs #2320.

comment:25 Changed 10 years ago by Peter Peterson

(In [10258]) Put operations in the proper order. Refs #2502 and #2320.

comment:26 Changed 10 years ago by Peter Peterson

(In [10544]) For some reason a couple of nomad files are missing a log. Refs #2320.

comment:27 Changed 10 years ago by Peter Peterson

(In [10548]) Added error checking on min/max tof. Refs #2320.

comment:28 Changed 10 years ago by Peter Peterson

(In [10549]) More black magic with tmin/tmax. Refs #2320.

comment:29 Changed 10 years ago by Peter Peterson

(In [10579]) Moving code to get minimum TOF of an EventWorkspace into the class itself. Refs #2320.

comment:30 Changed 10 years ago by Peter Peterson

(In [10580]) The result of converting TOF->d-spacing should not be a negative number. Adding check for event workspaces. Refs #2320.

comment:31 Changed 10 years ago by Peter Peterson

(In [10582]) Error check the offsets when reading in. Refs #2320.

comment:32 Changed 10 years ago by Peter Peterson

(In [10583]) Made the bin masking stuff a bit smarter. Refs #2320.

comment:33 Changed 10 years ago by Peter Peterson

(In [10604]) Added some additional sanity checks that will boost performance in edge cases. Refs #2320.

comment:34 Changed 10 years ago by Peter Peterson

(In [10605]) More error checking. Refs #2320.

comment:35 Changed 10 years ago by Peter Peterson

(In [10617]) Fixed broken header (again). Refs #2320 and #2647.

comment:36 Changed 10 years ago by Peter Peterson

(In [10700]) Initialized value so it doesn't randomly fail. Refs #2320.

comment:37 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:38 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:39 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:40 Changed 9 years ago by Peter Peterson

In [15356]:

Fixing up the code so it can run NOMAD to produce GSAS from a single run. Refs #2320.

comment:41 Changed 9 years ago by Peter Peterson

Do not need to rebin in TOF once conversion is done. Refs #2320.

Changeset: 3661aa2671c5bccae03a80842bad839f0a7d8549

comment:42 Changed 9 years ago by Peter Peterson

Do not need to rebin in TOF once conversion is done. Refs #2320.

Changeset: 3661aa2671c5bccae03a80842bad839f0a7d8549

comment:43 Changed 9 years ago by Peter Peterson

Clearing out the MRU at the end of AlignDetectors. Refs #2320.

Changeset: c5e1e79b0ece9e96c96d78a7c7ffbc6ac9cf7c33

comment:44 Changed 9 years ago by Peter Peterson

learing out the MRU at the end of ConvertUnits. Refs #2320.

Changeset: 5f72c913e10e37eaef1d69df6682b22fef1c3571

comment:45 Changed 9 years ago by Peter Peterson

Restoring old version of SNSPowderReduction (mostly). Refs #2320.

Changeset: 761a8d892126d781321b70e6768bb1d22fba3cdd

comment:46 Changed 9 years ago by Peter Peterson

Made a minor mistake in the logic. Refs #2320.

Changeset: 3cba9cf7b0d6708ecfcf02d5998c4b4c062dab69

comment:47 Changed 9 years ago by Peter Peterson

Adding additional requirements to ISpectrum. Refs #4178 and #2320.

Also with default implementations.

Changeset: a5cb768144dc3a8abe8cc6887c04779a5d7c50f4

comment:48 Changed 9 years ago by Peter Peterson

Changing default FWHM value. Refs #2320.

Turns out that for powgen the peaks have a lot more points on them. Also adding a couple more tooltips for people to see the defaults.

Changeset: 48db66f290d34ce900866cec4025d82bc13b4462

comment:49 Changed 9 years ago by Peter Peterson

Hard coded focus position for NOMAD. Refs #2320.

Make it work, then make it correct. Next is to read the information from a file.

Changeset: 91624c10b8e69d9ab437fc7fe9011f35d2f151d7

comment:50 Changed 9 years ago by Peter Peterson

Folded in a proper version of the focus position information. Refs #2320.

Changeset: 0a585245d9b36506a4501a91879684c7ea8982ae

comment:51 Changed 9 years ago by Peter Peterson

Things have changed slightly. Refs #2320.

Changeset: f30f354539ebf072c474deacaa22f7f34c4e7539

comment:52 Changed 9 years ago by Peter Peterson

Getting the iparm filename into the workspace. Refs #4209 and #2320.

Changeset: 2fccc098b675b0b49e48b536bc1334e2a095ff63

comment:53 Changed 9 years ago by Peter Peterson

Using HighBackground option in StripVanadiumPeaks. Refs #2320.

Changeset: 4f0a080f0ba04f0095fff785720333d2de05e58d

comment:54 Changed 9 years ago by Peter Peterson

Dealing with spectra that have negative counts. Refs #2320.

Since background subtraction goes awry due to absorption effects, push all of the spectra to be above zero. Also added in a checkbox to only read in a partial event file for characterization runs.

Changeset: a08f27d197af3ab9f83c010e70f2da47b707c837

comment:55 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:56 Changed 9 years ago by Peter Peterson

Refs #2320. Added vanadium peak tolerance.

Changeset: 6a99312119901e307dd6ba6d0d46769841cf9b17

comment:57 Changed 9 years ago by Peter Peterson

Refs #2320. Improper passing of usews parameter.

Changeset: 9d696c82767af2543283afa01e1df0328ab6b7f9

comment:58 Changed 9 years ago by Peter Peterson

Refs #2320. Made loadPreNeXus a bit more rhobust.

Changeset: 4c34eae8b5d665af98215136c9eb967228f71c3b

comment:59 Changed 9 years ago by Peter Peterson

Refs #2320. Adding prenexus file to run files.

Changeset: f5fce1d3441c34bec372adb1f7bbf640f2ec6a05

comment:60 Changed 9 years ago by Peter Peterson

Refs #2320. Fixed file extensions for prenexus.

Changeset: c044fe43e1c9025dca28ff867700c9c89dab74e0

comment:61 Changed 9 years ago by Peter Peterson

Refs #2320. Adding check to turn off making data positive.

Changeset: a994d0d1bc3a6edb42c1fb7e29bba4adb36107f1

comment:62 Changed 9 years ago by Peter Peterson

Refs #2320. Adding check to turn off making data positive.

Changeset: a994d0d1bc3a6edb42c1fb7e29bba4adb36107f1

comment:63 Changed 9 years ago by Peter Peterson

Refs #2320. Using new LoadPreNexus algorithm.

Changeset: f64a8ed0e6ec8b4aacaa62b6540dff2fc534f883

comment:64 Changed 9 years ago by Peter Peterson

Refs #2320. Got rid of -0. in uncertainties.

Changeset: 95ad9a8a571be3386b379484231a0ee3c1f27920

comment:65 Changed 9 years ago by Peter Peterson

Refs #2320. Fuller usage of ResetNegatives.

Changeset: 53b04ae6d62817bd0207ba308c8739370942d67a

comment:66 Changed 9 years ago by Peter Peterson

Refs #2320. Adding ability to use in memory van background.

Changeset: acee0944b07da1b64981d4691af9639543539c4b

comment:67 Changed 9 years ago by Peter Peterson

Refs #2320. Fixing bug in which characterizations to load.

Changeset: c0d6563974a267a2781d9a33776df89ad9037543

comment:68 Changed 9 years ago by Peter Peterson

Refs #2320. Reworked all of the grouping information.

Changeset: c8696950e614490ccb418f6e70d48fa31821d79c

comment:69 Changed 9 years ago by Peter Peterson

Refs #2320. Adding ability to use in memory van background.

Changeset: acee0944b07da1b64981d4691af9639543539c4b

comment:70 Changed 9 years ago by Peter Peterson

Refs #2320. Fixing bug in which characterizations to load.

Changeset: c0d6563974a267a2781d9a33776df89ad9037543

comment:71 Changed 9 years ago by Peter Peterson

Refs #2320. Reworked all of the grouping information.

Changeset: c8696950e614490ccb418f6e70d48fa31821d79c

comment:72 Changed 9 years ago by Martyn Gigg

Backported NOMAD IDF updates.

Refs #4938. Fixed nomad grouping spectra again.

Refs #4398. Changed the group numbers for NOMAD.

Refs #2320. Reworked all of the grouping information. (cherry-picked from c8696950e614490ccb418f6e70d48fa31821d79c, fcbbc89fb1e97ba7aa3bd93609f5b3740b02ed33 and 2acf3b928c78e63e75da6819a69f2b601fad4f0a)

Changeset: 7502ee8ecf0e1e3084bef5706409e5767521f771

comment:73 Changed 9 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

This ticket is being closed on the principle that it is just a dumping ground for changes. The person who "verifies" it should probably close it without asking too many questions.

comment:74 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:75 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Closed without asking too many questions!

comment:76 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3167

Note: See TracTickets for help on using tickets.