Ticket #2330 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Load: Improved Python flexibility

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: critical Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Extend the python scripting support for Load to allow uses to specifiy any properties they want, in addition to Filename and OutputWorkspace. When executing do the following:

  1. Use the Load Algorithm to select the specific Loader to use.
  2. Pass on the properties including any user specified ones that match.
  3. Log any that mismatch (warning)
  4. Execute

Change History

comment:1 Changed 10 years ago by Martyn Gigg

(In [9455]) Add more flexible simple API command for Load. Re #2330. Clean up for memory leak in LoadSNSNexus. Re #2394

comment:2 Changed 10 years ago by Martyn Gigg

(In [9458]) Fix the test. Re #2330

comment:3 Changed 10 years ago by Martyn Gigg

(In [9471]) Fix a test and implement LoadDialog python function. Refs #2330 and Refs #2394

comment:4 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:5 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 10 years ago by Mathieu Doucet

(In [9480]) Fix broken API. Re #2330

comment:7 Changed 10 years ago by Mathieu Doucet

(In [9484]) Reverting MantidFramework import * for now since it breaks everything. We can revisit this after the release. Re #2330

comment:8 Changed 10 years ago by Mathieu Doucet

(In [9485]) Fixed missing import Re #2330

comment:9 Changed 10 years ago by Mathieu Doucet

(In [9487]) Fixed related test Re #2330

comment:10 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:11 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to closed

Works as advertised. Suggested spin-off #2413.

comment:12 Changed 10 years ago by Martyn Gigg

  • Status changed from closed to reopened
  • Resolution fixed deleted

Not quite.

comment:13 Changed 10 years ago by Martyn Gigg

  • Status changed from reopened to accepted

On Windows at least, Load(Filename='file',OutputWorkspace='w',EntryNumber=2) to load a nexus file for example skips the EntryNumber key word.

comment:14 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [9509]) Minor fix for Load Python picked up in testing. It was treating Filename and OutputWorkspace specially but not removing them from the keyword list if it had handle them. Fixes #2330

comment:15 Changed 10 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:16 Changed 10 years ago by Owen Arnold

  • Status changed from verifying to closed

Specifying keywords for FileName and OutputWorkspace now works. Tested with and without the presence of other keywords.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3177

Note: See TracTickets for help on using tickets.