Ticket #234 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Add custom validators for workspace properties

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 12
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Currently, the validation for a WorkspaceProperty is hard-coded. It then often turns out that you have to go checking the input workspace before you do anything else in the exec() part of an algorithm.

Change History

comment:1 Changed 12 years ago by Russell Taylor

(In [1378]) Added some validators for workspace properties, including a CompositeValidator so that a number of validators for a workspace can be attached to the same WorkspaceProperty. The WorkspaceProperty::isValid method still checks the name and type of a workspace and that it exists (if input), but then also calls any validators attached to the property. Re #234.

comment:2 Changed 12 years ago by Russell Taylor

(In [1380]) DLLExports Re #234.

comment:3 Changed 12 years ago by Russell Taylor

(In [1381]) Tests for new validators. Re #234.

comment:4 Changed 12 years ago by Russell Taylor

(In [1382]) Fix tests on Windows. Re #234.

comment:5 Changed 12 years ago by Russell Taylor

(In [1389]) Turned out that workspace validators needed to be templated to cope with workspace properties of specific type (e.g. Workspace2D). Re #234.

comment:6 Changed 12 years ago by Russell Taylor

(In [1390]) Re #234.

comment:7 Changed 12 years ago by Russell Taylor

(In [1396]) Improvement to workspace validator and added a test. Re #234.

comment:8 Changed 12 years ago by Russell Taylor

  • Status changed from new to closed
  • Resolution set to fixed

This is now done, although the wiki documentation should be updated once these changes have made it into the released version.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1082

Note: See TracTickets for help on using tickets.