Ticket #2386 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Possible SEGFAULT in SaveNexusProcessedTest.testExecOnMuon

Reported by: Janik Zikovsky Owned by: Nick Draper
Priority: critical Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description (last modified by Russell Taylor) (diff)

Both testExecOnMuon and testExecOnMuonXML are currently disabled. If enabled, they crash on linux in the NexusFileIO::writeNexusProcessedSpectraMap method. The problem appears to be because the nDetectors variable is used to set the size of various arrays but this variable is initialised by calling spectraMap.nElements(), which is not necessarily the number of detectors.

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Priority changed from major to critical

Both testExecOnMuon and testExecOnMuonXML are currently disabled. If enabled, they crash on both linux and windows in the NexusFileIO::writeNexusProcessedSpectraMap method. The problem appears to be because the nDetectors variable is used to set the size of various arrays but this variable is initialised by calling spectraMap.nElements(), which is not necessarily the number of detectors.

comment:2 Changed 10 years ago by Russell Taylor

  • Description modified (diff)

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:4 Changed 10 years ago by Russell Taylor

  • Status changed from new to accepted
  • Owner set to Russell Taylor
  • Milestone changed from Iteration 28 to Iteration 27

comment:5 Changed 10 years ago by Russell Taylor

(In [9550]) Re-enable muon tests. The problem was that the test called the algorithm twice and there were member variables that held state that was not cleaned on re-running. Re #2386.

comment:6 Changed 10 years ago by Russell Taylor

SaveNexusProcessedTest::testExecOnMuonXml now failing on win32 during SaveNexusProcessed execution (line 293). OK on other platforms.

Here's the relevant section of the log from the buildserver:

2011-02-17 18:26:00,655 [0] Error NexusFileIO - Unable to open file C:\Program Files\CruiseControl\projects\Mantid\Code\Mantid\Framework\Build\Tests\SaveNexusProcessedTest_testExecOnMuonXml.xml
2011-02-17 18:26:00,655 [0] Error SaveNexusProcessed - Error in execution of algorithm SaveNexusProcessed:
2011-02-17 18:26:00,655 [0] Error SaveNexusProcessed - Unable to open File: in C:\Program Files\CruiseControl\projects\Mantid\Code\Mantid\Framework\Build\Tests\SaveNexusProcessedTest_testExecOnMuonXml.xml

comment:7 Changed 10 years ago by Russell Taylor

(In [9556]) Disable test again for now. Re #2386.

comment:8 Changed 10 years ago by Russell Taylor

  • Status changed from accepted to assigned
  • Owner changed from Russell Taylor to Nick Draper

Someone over there is going to have to look at the test failure (see above). I don't have a 32 bit windows box here.

comment:9 Changed 10 years ago by Nick Draper

  • Status changed from assigned to accepted

Investigated by Martyn:

The xml test is a throwback that should no longer exist. It was from when you might want to save your nexus file as xml, in which case you just called the file bob.xml

The current nexus libraries do not appear to support that anymore, and it was always a mistake to do this anyway as the xml files where HUGE and took forever to write. The test has been removed.

comment:10 Changed 10 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 10 years ago by Nick Draper

  • Status changed from verify to closed
  • Tester set to Nick Draper

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3233

Note: See TracTickets for help on using tickets.