Ticket #2470 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SANS: Problem with horizontal integral in the ISIS SANS diagnose tab

Reported by: Steve Williams Owned by: Gesner Passos
Priority: major Milestone: Release 2.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

Enter SANS2D2500 as the run number and click "Display Horizontal". The plot shows the maximum numbers of counts towards the edges of the plot (x=0) instead of near the centre(x~100)

Attachments

tik_2470.py (1.9 KB) - added by Gesner Passos 8 years ago.
Reproduce the error
correct_image.png (24.1 KB) - added by Gesner Passos 8 years ago.
wrong_image.png (25.2 KB) - added by Gesner Passos 8 years ago.

Change History

comment:1 Changed 10 years ago by Steve Williams

Generally confirm in instrument view that the spectra used in the rear and front-detector sums include all and only those actually in the detector

comment:2 Changed 10 years ago by Steve Williams

  • Blocked By 2435 added

Ticket #2435 should help things

comment:3 Changed 10 years ago by Steve Williams

  • Blocked By 2435 removed

(In #2435) There was also a change to the instrument configuration in cycle 4/9 (they used their working detector as the front instead of the rear)

comment:4 Changed 10 years ago by Nick Draper

  • Priority changed from critical to major
  • Owner set to Steve Williams
  • Status changed from new to assigned

Is this already resolved?

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:7 Changed 9 years ago by Anders Markvardsen

  • Owner changed from Steve Williams to Anders Markvardsen

comment:8 Changed 9 years ago by Anders Markvardsen

  • Status changed from assigned to accepted
  • Summary changed from Problem with display horizontal in the ISIS SANS diagnose tab to SANS: Problem with display horizontal in the ISIS SANS diagnose tab

comment:9 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:10 Changed 9 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to wontfix

There is no 'display horizontal' in the ISIS SANS Diagnostics tab

comment:11 Changed 9 years ago by Nick Draper

  • Status changed from verify to reopened
  • Resolution wontfix deleted
  • Milestone changed from Iteration 32 to Iteration 33

The name on the button was changed - it means Horizontal Integral

comment:12 Changed 9 years ago by Nick Draper

  • Summary changed from SANS: Problem with display horizontal in the ISIS SANS diagnose tab to SANS: Problem with horizontal integral in the ISIS SANS diagnose tab

comment:13 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:14 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:15 Changed 8 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Gesner Passos
  • Status changed from reopened to assigned

Changed 8 years ago by Gesner Passos

Reproduce the error

Changed 8 years ago by Gesner Passos

Changed 8 years ago by Gesner Passos

comment:16 Changed 8 years ago by Gesner Passos

Replying to Steve Williams:

Enter SANS2D2500 as the run number and click "Display Horizontal". The plot shows the maximum numbers of counts towards the edges of the plot (x=0) instead of near the centre(x~100)

The error is related to the definition of what are the Spectrums that belong to a single DetectorBank. For example, the DetectorBank='front' is a square Bank whose dectors IDs goes to 2,000,000 to 2,191,191. But, what you want is to get the SpectraIDs that were acquired by those detectorsIDs.

The current implementation inside SANSDiagnostics.cpp part from the following assumption:

"The minimum number (2,000,000) will be related to the minimum SpectrumID, analogous to the maximum"""

This assumption seems not to be valid for this file. And usually, in the moment of Croping the workspace to get only the data related to one DetectorBank it is sending without one row, but the SumRowColumn knows only how to execute integration on a square dataset. So, you get the wrong image.

That is why the SumRowColumn issues this warning:

The input workspace has 36482 spectra.This is not 128*128 or 192*192 - did you make a mistake?

I attached a python script that shows what is happening. Just execute the python code

comment:17 Changed 8 years ago by Gesner Passos

Solve getSpectraList wrong assumption

Change the calculation of the spectra ids limits from SANSDiagnosis that used to return a wrong range due to a false assumption. This patch solves the issue, but advise is given in order to improve the performance. re #2470

Changeset: e47d661bb1f18889046242cb8c8a65e0373ae922

comment:18 Changed 8 years ago by Gesner Passos

  • Status changed from assigned to accepted

comment:19 Changed 8 years ago by Gesner Passos

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:20 Changed 8 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:21 Changed 8 years ago by Karl Palmen

Unable to find ISIS SANS diagnose tab, but do find a SANS ISIS diagnostic tab. It has no "Display" horizontal. Other features are disabled. I don't seem to know enough about this GUI to do the test.

comment:22 Changed 8 years ago by Karl Palmen

  • Status changed from verifying to verify
  • Tester Karl Palmen deleted

comment:23 Changed 8 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:24 Changed 8 years ago by Nick Draper

  • Status changed from verifying to closed

This specific bug fixed, but two more created for the next iteration #6042 and #6043 for the next release

comment:25 Changed 8 years ago by Gesner Passos

Solve getSpectraList wrong assumption

Change the calculation of the spectra ids limits from SANSDiagnosis that used to return a wrong range due to a false assumption. This patch solves the issue, but advise is given in order to improve the performance. re #2470

Changeset: e47d661bb1f18889046242cb8c8a65e0373ae922

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3317

Note: See TracTickets for help on using tickets.