Ticket #2502 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Convert Hodges python code to mantid algorithm

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

The attached code is something that Jason wrote to do a couple of corrections to POWGEN data. It should be converted into Mantid algorithms and use Mantid constructs.

Attachments

pg_fix.py​ (9.0 KB) - added by Peter Peterson 10 years ago.
The actual program
powgen_dspacemap_d1370_2010_09_12.dat​ (2.3 MB) - added by Peter Peterson 10 years ago.
Calibration file that was sent with it

Change History

Changed 10 years ago by Peter Peterson

The actual program

Changed 10 years ago by Peter Peterson

Calibration file that was sent with it

comment:1 Changed 10 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 10 years ago by Peter Peterson

(In [9982]) Small fixes to the EventList to make getTofs/setTofs a bit more usable. Refs #2502.

comment:3 Changed 10 years ago by Peter Peterson

(In [10012]) Trying to get a version into the nightly build so more people can try it out. Refs #2502.

comment:4 Changed 10 years ago by Peter Peterson

(In [10071]) Fairly well working of new unwrap function. Refs #2502.

comment:5 Changed 10 years ago by Peter Peterson

(In [10072]) Added some todos to help in checkpointing. Refs #2502.

comment:6 Changed 10 years ago by Peter Peterson

(In [10075]) Removing previous testing version. Refs #2502.

comment:7 Changed 10 years ago by Peter Peterson

(In [10076]) Trying to make windows build work again. Refs #2502.

comment:8 Changed 10 years ago by Peter Peterson

(In [10077]) Trying to make windows build work again. Refs #2502.

comment:9 Changed 10 years ago by Peter Peterson

(In [10078]) Be careful what you commit. Refs #2502.

comment:10 Changed 10 years ago by Peter Peterson

(In [10087]) Adding code for removing events that Jason doesn't like. His words, not mine. Refs #2502.

comment:11 Changed 10 years ago by Michael Whitty

(In [10093]) re #2502 - temporarily renaming new algorithm so that old one can be used in scripts

comment:12 Changed 10 years ago by Peter Peterson

(In [10097]) Renaming to be consistent with the fact that it is a correction specific to the SNS DAS. Refs #2502.

comment:13 Changed 10 years ago by Peter Peterson

(In [10100]) Forgot to update the guards. Refs #2502.

comment:14 Changed 10 years ago by Peter Peterson

(In [10104]) Changed version to 1. Refs #2502.

comment:15 Changed 10 years ago by Peter Peterson

(In [10105]) Added Jason's algorithms to the reduction script. Refs #2502.

comment:16 Changed 10 years ago by Peter Peterson

(In [10126]) Exposed the Jason stuff to all users of the script with them off by default. Refs #2502.

comment:17 Changed 10 years ago by Peter Peterson

(In [10140]) Added call to carry the detector masks. Refs #2502.

comment:18 Changed 10 years ago by Peter Peterson

(In [10145]) Added support for histograms. Refs #2502.

comment:19 Changed 10 years ago by Peter Peterson

(In [10146]) Commenting out the ForceHist option for now. It isn't going to be figured out soon. Refs #2502.

comment:20 Changed 10 years ago by Peter Peterson

(In [10252]) Adding functions to get the minimum and maximum tof value in the event list. Refs #2502.

comment:21 Changed 10 years ago by Peter Peterson

(In [10256]) Smarter minimum tof selection from data. Refs #2502.

comment:22 Changed 10 years ago by Peter Peterson

(In [10257]) Smarter minimum tof selection from data. Refs #2502.

comment:23 Changed 10 years ago by Peter Peterson

(In [10258]) Put operations in the proper order. Refs #2502 and #2320.

comment:24 Changed 10 years ago by Peter Peterson

(In [10318]) Adding in tests. Refs #2502.

comment:25 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

The last commit resolved this issue.

comment:26 Changed 9 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:27 Changed 9 years ago by Peter Peterson

  • Status changed from reopened to accepted

comment:28 Changed 9 years ago by Peter Peterson

(In [10882]) Fixed minor bug with how you get minimum double. Refs #2502.

comment:29 Changed 9 years ago by Peter Peterson

(In [10905]) Added parameter to make clearing out the detector ids optional. Refs #2502.

comment:30 Changed 9 years ago by Peter Peterson

(In [10907]) Moved to use more of AlignDetectors for calculating tof to d conversion and added diagnostic messages. Refs #2502.

comment:31 Changed 9 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [11080]) Missing a very important if statement. Fixes #2502.

comment:32 Changed 9 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:33 Changed 9 years ago by Peter Peterson

  • Status changed from reopened to accepted

comment:34 Changed 9 years ago by Nick Draper

Pete says this is ready to test

comment:35 Changed 9 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:36 Changed 9 years ago by Peter Peterson

This can be tested by reducing PG3 1370 with and without frame unwrapping and filtering low resolution. This run already has the corrections done on the raw data so the extra corrections should not have an effect.

comment:37 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:38 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

Tested SNSPowderReduction using PG3_1370 with and without UnwrapRef=16666 and LowResRef=15000 and results look the same.

comment:39 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3349

Note: See TracTickets for help on using tickets.