Ticket #2633 (closed: wontfix)

Opened 10 years ago

Last modified 5 years ago

Improve Algorithm search results box

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Andrei Savici

Description (last modified by Russell Taylor) (diff)

The algorithm search currently just autocompletes based on the existing algorithms.

We should improve this to either

  1. Drop a list box down containing all matches
  2. Dynamically update the category list box to just contain the matching entries (don't list categories in this case).

Also the search should match anywhere in the string, not just the start.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:6 Changed 8 years ago by Peter Peterson

  • Cc petersonpf@… added

The solution appears to be in this stack overflow question that Russell found. The magic source file (for now) is AlgorithmSelectorWidget.

comment:7 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted
  • Owner changed from Martyn Gigg to Russell Taylor

I'm going to pinch this one.....

comment:8 Changed 8 years ago by Russell Taylor

Re #2633. Match anywhere in algorithm name when typing in combobox.

Once 2 characters have been entered in the AlgorithmDock combobox's lineedit, all algorithms that match the entered string anywhere in their name should pop up.

There seem to be problems on RHEL6 though so this may not stick.

Changeset: 5e0bdea6890b7c074f3d18e9fdc503b11aa5b795

comment:9 Changed 8 years ago by Russell Taylor

Revert "Re #2633. Match anywhere in algorithm name when typing in combobox."

Unfortunately, this didn't work properly on Linux so we'll need to go back to the old way.

This reverts commit 5e0bdea6890b7c074f3d18e9fdc503b11aa5b795.

Changeset: 19ffaa5021de95c05e2882be21fde7e76d0833db

comment:10 Changed 8 years ago by Russell Taylor

Revert "Re #2633. Match anywhere in algorithm name when typing in combobox."

Unfortunately, this didn't work properly on Linux so we'll need to go back to the old way.

This reverts commit 5e0bdea6890b7c074f3d18e9fdc503b11aa5b795.

Changeset: 19ffaa5021de95c05e2882be21fde7e76d0833db

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:12 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to assigned
  • Milestone changed from Release 2.3 to Release 2.4

comment:13 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:14 Changed 7 years ago by Russell Taylor

  • Milestone changed from Release 2.5 to Release 2.6

Move the tickets I'm definitely not going to do this iteration so that I can better see the ones that I might.

comment:15 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:16 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:17 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:18 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:19 Changed 6 years ago by Russell Taylor

  • Owner changed from Russell Taylor to Anyone
  • Description modified (diff)

Just checked again, and (unsurprisingly really) the same problem still exists on RHEL6 whereby the pop-up box is grey and blank. A pity, because this solution worked a treat on Windows & Mac.

I guess I'll put this ticket into the 'Anyone' morass - maybe the problem will go away once we move onto newer linuxes.

Last edited 6 years ago by Russell Taylor (previous) (diff)

comment:20 Changed 6 years ago by Nick Draper

  • Status changed from assigned to verify
  • Owner changed from Anyone to Nick Draper
  • Resolution set to wontfix

This appears to be a RHEL 6 special, but also does not appear on all machines, a quick test with mantidlx1 over X looks just fine.

As RHEL 7 or a move to fedora is around the corner I will mark this as wontfix.

The suggested change to matching algorithms anywhere in the string is not worth while and would likely throw up more confusion than the current start of string matching.

comment:21 Changed 6 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.3

comment:22 Changed 6 years ago by Peter Peterson

I still think this would be a very useful improvement.

comment:23 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:24 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3480

Note: See TracTickets for help on using tickets.