Ticket #2638 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Minus: Add tests; fix event workspace subtraction with one bin

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

EW with one bin - EW with one bin now complains. Easy fix

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted
  • Summary changed from Minus: Add tests; fix event workspace to Minus: Add tests; fix event workspace subtraction with one bin

comment:2 Changed 10 years ago by Janik Zikovsky

(In [9997]) Refs #2638: Fix minus for unbinned eventworkspace

comment:3 Changed 10 years ago by Janik Zikovsky

(In [9998]) Refs #2638: A bunch more tests for plus and minus operations. Trying a fix to the occasional windows divide error.

comment:4 Changed 10 years ago by Janik Zikovsky

(In [9999]) Refs #2638: Added yet more tests for Multiply and Divide

comment:5 Changed 10 years ago by Janik Zikovsky

(In [10000]) Refs #2638: SVN revision 10000 !

comment:6 Changed 10 years ago by Janik Zikovsky

(In [10008]) Refs #2012: MDEvents target; Refs #2638: Use the same fix for Multiply as for divide.

comment:7 Changed 10 years ago by Janik Zikovsky

(In [10009]) Refs #2638: Use the same fix for Multiply as for divide.

comment:8 Changed 10 years ago by Janik Zikovsky

(In [10027]) Refs #2638: MultiplyTest and DivideTest now are auto-generated from the same base. Added a large test that is more likely to catch the odd incorrect value.

comment:9 Changed 10 years ago by Janik Zikovsky

(In [10028]) Refs #2638: Common test file for Plus and Minus test

comment:10 Changed 10 years ago by Janik Zikovsky

(In [10029]) Refs #2638: More reporting when errors occur.

comment:11 Changed 10 years ago by Janik Zikovsky

(In [10030]) Refs #2638: Take multithreading off (temporarily) in BinaryOperation to see if that fixes it.

comment:12 Changed 10 years ago by Janik Zikovsky

(In [10033]) Refs #2638: Last 5 tests or so passed on windows with OpenMP disabled. Re-enabling to see if it fails again.

comment:13 Changed 10 years ago by Russell Taylor

Work on the occasional windows binary operation errors continues in #2669.

comment:14 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:15 Changed 9 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:16 Changed 9 years ago by Anders Markvardsen

  • Status changed from verifying to closed

For test substrated CNCS_7860_event by a single-value workspace. In general looks well tested.

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3485

Note: See TracTickets for help on using tickets.