Ticket #2714 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Deleting a workspace while a python script is running crashes MantidPlot

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Iteration 28
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

To reproduce:

  • Load a separate workspace, the size is irrelevant we want just want something to delete;
  • Write a small python script in the MantidPlot script window that will take > 10 seconds to run (i.e. load a large data set);
  • Execute the script;
  • Go the first workspace that was loaded and click on the delete button
  • Crash!

This is due to the call back in to Python when a workspace is deleted so that it can free any handles there.

Change History

comment:1 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [10289]) Fixes #2714. Fix crash in MantidPlot when deleting a workspace while a script is running. Managed to removed the need to set whether the GIL is acquired as I found the magic Python function that tells me whether there is a current thread state or not and more importantly doesn't crash if there wasn't!

comment:3 Changed 10 years ago by Martyn Gigg

(In [10292]) Re #2714. Fix test build.

comment:4 Changed 9 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:5 Changed 9 years ago by Michael Whitty

  • Status changed from verifying to closed

tested in 11062

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3561

Note: See TracTickets for help on using tickets.