Ticket #2720 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Display mask in the InstrumentView superimposed on the data in another color

Reported by: Steve Williams Owned by: Roman Tolchenov
Priority: major Milestone: Release 2.0
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

It would be useful to see the mask superimposed on the counts data in the InstrumentView in another colour, like say grey. It would stop the mask from being in the wrong place letting odd stray pixels into the final results.

At the moment masked pixels show as zeros amoungst other zeros in the data.

From Richard

Re: I can make Display Mask display the masking superimposed on a sample run workspace as a diagnostic.
That would be very good!

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:3 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Roman Tolchenov

Something like this could be done with the masking tab on the instrument display.

We can't do it to already masked data, as we have lost the values by then.

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:5 Changed 9 years ago by Roman Tolchenov

  • Status changed from assigned to accepted

comment:6 Changed 9 years ago by Roman Tolchenov

Ref #2720. Show masked detectors in grey rather the zero color

Changeset: c0af1f90f6cfa2207e966711cfe9f2210cd5d206

comment:7 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 9 years ago by Roman Tolchenov

Ref #2720. Show masked detectors in grey rather the zero color

Changeset: c0af1f90f6cfa2207e966711cfe9f2210cd5d206

comment:9 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:10 Changed 9 years ago by Vickie Lynch

I have a question about this ticket. The grey color appears if I use the mask tab to mask some pixels, but not for pixels already masked by MaskDetectors. Can you also check wksp->maskedBins(i) for spectrum i?

comment:11 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

After discussing with Roman, I retested and the pixels that were masked with MaskDetectors were grey.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3567

Note: See TracTickets for help on using tickets.