ConvertUnits from d-space to momentum transfer is broken for event workspaces

[Peter Peterson]

This is a fun one:

# Set up the data in d-spacing                                                                                           
LoadEventNexus("/SNS/PG3/IPTS-1582/0/2581/NeXus/PG3_2581_event.nxs", "PG3_2581", CompressTolerance=.01)
ws = mtd["PG3_2581"]
calib_fname="/SNS/PG3/2011_2_11A_CAL/PG3_FERNS_2656_2011_03_20.cal"
AlignDetectors(ws, ws, calibfile)
DiffractionFocussing(ws, ws, calibfile)
CompressEvents(ws, ws, Tolerance=.00000001)
NormaliseByCurrent(ws, ws)
Rebin(ws, ws, Params=(.1,-.0004,5))

# Make a copy that is a histogram                                                                                        
ConvertToMatrixWorkspace(ws, str(ws) + "_h")
hist = mtd[str(ws)+"_h"]

# Convert both to momentum transfer                                                                                      
ConvertUnits(ws, ws, Target="MomentumTransfer")
ConvertUnits(hist, hist, Target="MomentumTransfer")

PG3_2581_h has the right answer. The one for the event list not only has the wrong aswer, rebinning the data will delete the events in the list.

[Peter Peterson]

(In [10401]) Got the convertQuickly doing the right thing for events now. Fixes #2737.

[Andrei Savici]

I assumed calibfile and calib_fname are the same. Then it's ok

[Stuart Campbell]

This ticket has been transferred to github issue ​3584