Ticket #2832 (closed: wontfix)

Opened 9 years ago

Last modified 5 years ago

Make accessing workspaces using mtd safer

Reported by: Nick Draper Owned by: Robert Whitley
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

From Pascal:

If you load a workspace using the mtd command but mistype the name of the workspace (or forget to put quote for instance), Mantid doesn't tell you that what you have loaded is empty. You can then operate on it for a while and think everything is OK.

Perhaps we could just print a warning message out of python is the key is not found?

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:2 Changed 9 years ago by Mathieu Doucet

Would be useful to know which mtd command we are talking about. Sample code would be nice.

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:4 Changed 9 years ago by Martyn Gigg

  • Status changed from new to assigned
  • Owner changed from Martyn Gigg to Robert Whitley

Fairly simple isolated one for Robert to do for an hour

comment:5 Changed 9 years ago by Robert Whitley

  • Status changed from assigned to accepted

comment:6 Changed 9 years ago by Robert Whitley

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 9 years ago by Robert Whitley

Refs #2832 Implemented a key error message when the user enters the wrong workspace name.

comment:8 Changed 9 years ago by Martyn Gigg

In [13615]:

Refs #2832 Revert this for now as it seems several scripts rely on checking the return value.

comment:9 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:10 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Change was reverted. Do you want to resolve as wontfix?

comment:11 Changed 9 years ago by Robert Whitley

  • Status changed from reopened to accepted

comment:12 Changed 9 years ago by Robert Whitley

  • Status changed from accepted to verify
  • Resolution set to wontfix

comment:13 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Janik Zikovsky to Martyn Gigg

comment:14 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Given that so many current scripts rely on this behaviour it makes sense to make this kind of change with the new API.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3679

Note: See TracTickets for help on using tickets.