Ticket #2888 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Make He3TubeEfficiency event aware

Reported by: Stuart Campbell Owned by: Michael Reuter
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

Add the ability to cope with event workspaces to He3TubeEfficiency algorithm

Change History

comment:1 Changed 9 years ago by Michael Reuter

  • Milestone changed from Iteration 29 to Iteration 30

comment:2 Changed 9 years ago by Michael Reuter

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Michael Reuter

(In [12983]) Starting event processing work. Runs but doesn't do anything yet. This refs #2888.

comment:4 Changed 9 years ago by Michael Reuter

(In [12986]) Moving exponential factor calculation to its own function. This refs #2888.

comment:5 Changed 9 years ago by Michael Reuter

(In [12996]) Adding calculation and application to events and fixing integer warnings. Now to update test. This refs #2888.

comment:6 Changed 9 years ago by Michael Reuter

(In [12997]) Windows fixes and doxygen updates. This refs #2888.

comment:7 Changed 9 years ago by Michael Reuter

(In [13000]) Checking event calculations in test. This refs #2888.

comment:8 Changed 9 years ago by Michael Reuter

(In [13002]) Handling pixel skipping for events. This refs #2888.

comment:9 Changed 9 years ago by Michael Reuter

(In [13008]) Clearing event list if parameters are bad in lieu of masking. This refs #2888.

comment:10 Changed 9 years ago by Michael Reuter

In [13833]:

Using inbuilt spectra masking instead of my own. This refs #2888.

comment:11 Changed 9 years ago by Michael Reuter

In [13837]:

Fixing warning that natty compile missed. This refs #2888.

comment:12 Changed 9 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

In [13898]:

Fixing error scaling and adding test check. This fixes #2888.

comment:13 Changed 9 years ago by Michael Reuter

To test:

  1. Read in CNCS_7860_event.nxs from AutoTestData
  2. Run ConvertUnits to wavelength: Use Direct for EMode and EFixed equal 3.0
  3. Run He3TubeEfficiency
  4. Algorithm should not crash and the workspace should be an EventWorkspace

comment:14 Changed 9 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:15 Changed 9 years ago by Stuart Campbell

  • Status changed from verifying to closed

I do indeed get a weighted event workspace out.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3735

Note: See TracTickets for help on using tickets.