Ticket #2919 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Remove HDF5 dependencies from VATES

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Iteration 29
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Russell Taylor has reported that our HDF5 dependencies for VATES are a show-stopper for providing a true cross-platform working version. This is a critical step that must be tacked.

As we are only using the HDF5 libraries for one of the file readers in MDDataObjects, and that file reader is never actually used, we should be able to cut the dependency out altogether.

Change History

comment:1 Changed 9 years ago by Owen Arnold

(In [11289]) re #2919 Remove HDF5 dependencies from MDAlgorithms, MDDataObjects and VATES. Tested on Windows and Linux prior to commit. Also, removed shared/dynamic hdf5 libraries on windows as part of testing. Have deliberately not removed much existing hdf5 dependent source code.

comment:2 Changed 9 years ago by Owen Arnold

(In [11320]) re #2919 MDAlgorithms MDDatataObjects and MDEvents should now be on build server. MDEvents may be switched off.

comment:3 Changed 9 years ago by Martyn Gigg

(In [11335]) Refs #2919. Fixes for the Mac. For some reason a few files in MDAlgorithms had a ? character at the start of the file which was causing the compiler to fall over. I don't know where this came from ...

comment:4 Changed 9 years ago by Owen Arnold

(In [11336]) re #2919 Make it so that building of MD types is optional. Temporary fix before size of VATES *.sqw files are reduced.

comment:5 Changed 9 years ago by Owen Arnold

  • Status changed from new to accepted

comment:6 Changed 9 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:7 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:8 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

I can't find hdf5 references outside of MD_File_hdfMatlab, which is not in CMakeLists.txt, so that should be okay.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3766

Note: See TracTickets for help on using tickets.