Ticket #3099 (closed: worksforme)

Opened 9 years ago

Last modified 5 years ago

LoadNexusMonitors does not load ISIS monitors

Reported by: Freddie Akeroyd Owned by: Freddie Akeroyd
Priority: major Milestone: Release 2.4
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

SNS monitors are named monitor* whereas ISIS monitors are named monitor_*

Change History

comment:1 Changed 9 years ago by Freddie Akeroyd

(In [12090]) Check for monitor_* as well as monitor* when loading monitors. A separate bit of work may be required to get the spectrum number correct. refs #3099

comment:2 Changed 9 years ago by Martyn Gigg

(In [12114]) Update to LoadEventNexus and LoadNexusMonitors to read in the spectra table from the NeXus file if it exists. It is only defined for the isis_vms_compat block at the moment. Refs #3106 #3099

comment:3 Changed 9 years ago by Alex Buts

does it not clashes with ticket: Re: [Mantid Tickets] #3151: UpdateInstrumentFromFile should ignore monitors ?

The monitors in some raw files have incorrect values or incorrect sign, so it is easier to use xml definition as a source for the monitors positions.

The same problem sometimes occurs with detectors positions but it is much more difficult to handle.

comment:4 Changed 9 years ago by Martyn Gigg

Alex: No this is actually about loading the data from the monitors from an Event NeXus file. The UpdateInstrument code is handle by LoadInstrument.

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:7 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:12 Changed 8 years ago by Freddie Akeroyd

  • Status changed from new to verify
  • Resolution set to worksforme

comment:13 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:14 Changed 8 years ago by Stuart Campbell

  • Milestone changed from Release 2.5 to Release 2.4

comment:15 Changed 8 years ago by Stuart Campbell

  • Status changed from verifying to closed

Tested with a couple of ISIS files from the systemtests data directory and all seems to work.

The only issue is the normal one if there are some event and some histogram monitors in the same file - but this is a general known issue.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3946

Note: See TracTickets for help on using tickets.