Ticket #3136 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Speed up AlgorithmHistory operations

Reported by: Russell Taylor Owned by: Nick Draper
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description (last modified by Nick Draper) (diff)

Creating the Algorithm history can be outrageously slow if there's a large ArrayProperty involved. I had an algorithm that took 0.2s to run, but 22 seconds to deal with the history operations!

Note that 2 AlgorithmHistory objects are constucted: the algorithm_info creates a temporary one for the logging messages, presumably on the assumption that it would be fast. fillHistory then creates another one.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:2 Changed 9 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Anyone

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:5 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:9 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:10 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:11 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:12 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:13 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:14 Changed 6 years ago by Nick Draper

  • Status changed from assigned to verify
  • Owner changed from Anyone to Nick Draper
  • Resolution set to invalid
  • Description modified (diff)

This has been addressed by the changes Sam made

comment:15 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:16 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

comment:17 Changed 6 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.4

moved to r 3.4 as tickets are closed

comment:18 Changed 5 years ago by Nick Draper

  • Resolution changed from invalid to fixed

Somehow these slipped through without a resolution. Set to Fixed.

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​3983

Note: See TracTickets for help on using tickets.