Ticket #3156 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

LoadRaw crashes on select [recent] TOSCA runs

Reported by: Michael Whitty Owned by: Nick Draper
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

These ones:

  • TSC12330Ross Professor N L Al2O3:H20 Sample D <20K 04-JUN-2011 11:00:45 3410.4
  • TSC12331Ross Professor N L Al2O3:H20 Sample B <20K 05-JUN-2011 11:06:54 3037.3

Find out why. Try and solve it.

Change History

comment:1 Changed 9 years ago by Michael Whitty

  • Status changed from new to accepted

Data files can be found at:
NDW615\DATA\ (obviously, only from within RAL)

Reproduced in revision [12405] - (nightly development build of 08/06/11 00:44:28)

Debug trace: 

msvcr100d.dll!_free_dbg_nolock(void * pUserData, int nBlockUse)  Line 1376 + 0x5e bytes	C++
msvcr100d.dll!_free_dbg(void * pUserData, int nBlockUse)  Line 1265 + 0xe bytes	C++
msvcr100d.dll!operator delete(void * pUserData)  Line 54 + 0x12 bytes	C++
msvcr100d.dll!operator delete[](void * p)  Line 22	C++
MantidDataHandling.dll!ISISRAW2::~ISISRAW2()  Line 126	C++
MantidDataHandling.dll!ISISRAW2::`scalar deleting destructor'()  + 0x2c bytes	C++
MantidDataHandling.dll!boost::checked_delete<ISISRAW2>(ISISRAW2 * x)  Line 34 + 0x30 bytes	C++
MantidDataHandling.dll!boost::detail::sp_counted_impl_p<ISISRAW2>::dispose()  Line 79	C++
MantidDataHandling.dll!boost::detail::sp_counted_base::release()  Line 103	C++
MantidDataHandling.dll!boost::detail::shared_count::~shared_count()  Line 221	C++
MantidDataHandling.dll!boost::shared_ptr<ISISRAW2>::~shared_ptr<ISISRAW2>()  + 0x2f bytes	C++
MantidDataHandling.dll!boost::shared_ptr<ISISRAW2>::reset()  Line 387	C++
MantidDataHandling.dll!Mantid::DataHandling::LoadRawHelper::reset()  Line 133	C++
MantidDataHandling.dll!Mantid::DataHandling::LoadRaw3::exec()  Line 299	C++

OpenGENIE apparently reads these files without complaint.

comment:2 Changed 9 years ago by Michael Whitty

(In [12431]) refs #3156 - prevent buffer overflow / heap corruption in load raw with a new user property.

comment:3 Changed 9 years ago by Martyn Gigg

(In [12439]) Move the check of loadraw.readbuffer.size to the constructor of ISIRAW2 and update the copy in NeXus. This will fix the Mac test failures. Re #3156. Ticket #3160 has been raised to decide what to do about the duplication.

comment:4 Changed 9 years ago by Michael Whitty

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Nick Draper

  • Owner changed from Michael Whitty to Martyn Gigg

Moved from Michael Whitty, ask Martyn if you have any questions during testing

comment:6 Changed 9 years ago by Nick Draper

  • Owner changed from Martyn Gigg to Nick Draper

Moved so they can be tested

comment:7 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified that both of the mentioned runs load correctly and the debug statements verify that the ISISRAW buffer size is being correctly set.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4003

Note: See TracTickets for help on using tickets.