Ticket #3157 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Sort out system.h

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

System.h has become a dumping ground and needs to be tidied up.

It should only contains things that every file in Mantid should see. Everything else should be moved to other relevant headers and big notice telling people to only touch the file if absolutely necessary should be added.

Change History

comment:1 Changed 9 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Martyn Gigg

(In [12406]) Refs #3157 Sort our System.h. It was becoming a dumping ground. It should only be touched when absolutely necessary as it affects every file in Mantid. Also combined this with Refs #2345 to sort out DLLExport/DLLImport usage. It's done for Kernel, Geometry and API but stuff in the plugins could do with updating as well.

comment:3 Changed 9 years ago by Martyn Gigg

(In [12408]) Fix for lucid. Re #3157

comment:4 Changed 9 years ago by Martyn Gigg

(In [12409]) Fix for inline function. Refs #3157

comment:5 Changed 9 years ago by Martyn Gigg

(In [12410]) Fix for windows build. Refs #3157

comment:6 Changed 9 years ago by Russell Taylor

(In [12414]) Fix Mac build. Re #3157.

comment:7 Changed 9 years ago by Martyn Gigg

(In [12415]) Fix windows builds. Re #3157

comment:8 Changed 9 years ago by Martyn Gigg

(In [12417]) Fix windows build. A clean build was successful for me so that may be required. Re #3157

comment:9 Changed 9 years ago by Martyn Gigg

(In [12421]) Fix windows tests? Re #3157

comment:10 Changed 9 years ago by Martyn Gigg

(In [12425]) Fix for ADS linkage and tidy up Exception linkage. Re #3157

comment:11 Changed 9 years ago by Martyn Gigg

(In [12426]) Fix the MantidPlot build and fix a bug in the SpectraDetectorMap iterator. Refs #3157 and 3106

comment:12 Changed 9 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 9 years ago by Martyn Gigg

(In [12460]) Kill an inconsistent dll linkage warning. For some reason there were two copies of the same function declared. Re #3157

comment:14 Changed 9 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:15 Changed 9 years ago by Owen Arnold

  • Status changed from verifying to closed

Cleaner system.h, bold warning.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4004

Note: See TracTickets for help on using tickets.