Ticket #3173 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

Make the Peak Picking tool output a Peaks workspace

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: blocker Milestone: Iteration 29
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

At the moment it output a custom table workspace, it should be changed to ouptut a peaks workspace.

This needs doing ASAP to ensure other people can change their code to match.

Change History

comment:1 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 9 years ago by Roman Tolchenov

(In [12533]) Some modifications to the PeaksWorkspace. Outputting Qx, Qy, and Qz to a PeaksWorkspace from the instrument view. re #3173

comment:3 Changed 9 years ago by Roman Tolchenov

(In [12536]) Fixed a test. re #3173

comment:4 Changed 9 years ago by Roman Tolchenov

(In [12537]) Fixing other tests. re #3173

comment:5 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 9 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:7 Changed 9 years ago by Andrei Savici

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Does not work for me. It creates a peaks workspace, with 0 peaks, and I cannot add any peak. Also, a major deficiency as I see in the code, it requires the workspace to be in units of TOF. To be useful, the workspace must be d-spacing or momentum transfer

comment:8 Changed 9 years ago by Roman Tolchenov

(In [12899]) Added unit conversion to the peak picking tool. re #3173

comment:9 Changed 9 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:10 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Andrei Savici to Martyn Gigg

comment:12 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to verify
  • Tester Martyn Gigg deleted

Not sure I understand this enough to test it fully.

comment:13 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:14 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

I did get a PeaksWorkspace with 3 peaks from TOPAZ data using pick peaks.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4020

Note: See TracTickets for help on using tickets.