Ticket #3174 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

The peak picking tool should work for ineslatic, direct and indirect

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

At the moment the results are only right for elastic experiments. This is because the setting for the unit conversion energy mode is set that way.

Also the tool should work in any unit, not just TOF. This means using the unit code in Mantid.

Perform a lookup for the detector for some Params: 

If it has an Ei param - Direct
If it has an Efixed param - Indirect
otherwise - elastic

Check the names and casing of the param names in ConvertUnits.

This decision code should be with the unit code somewhere as it is likely to be of wider use in the future.

Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:2 Changed 9 years ago by Roman Tolchenov

(In [12963]) Do checks for Ei and Efixed params. Although I am not sure about Efixed: after converting units using the indirect emode I don't see the Efixed parameter. If none of the params is there a dialog pops up asking for emode and efixed. re #3174

comment:3 Changed 9 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:4 Changed 9 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 9 years ago by Andrei Savici

Quick comment: for indirect, there might be different final energies for each detector pixel

comment:6 Changed 9 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:7 Changed 9 years ago by Peter Peterson

  • Status changed from verifying to closed

Reviewing the change to the source code, this was done correctly.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4021

Note: See TracTickets for help on using tickets.