Ticket #3200 (closed: fixed)

Opened 9 years ago

Last modified 5 years ago

EQSANS: Mantid crashes if beam center is set to (0,0)

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description


Change History

comment:1 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:2 Changed 9 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:3 Changed 9 years ago by Mathieu Doucet

(In [12941]) Minor change to EQSANS system test. Should not change results. Re #3200

comment:4 Changed 9 years ago by Mathieu Doucet

(In [12942]) Fix problem with beam center being outside the detector. Re #3200

comment:5 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

Should now be fixed. To test, use the SANS reduction UI and do the following:

  • export to a python script,
  • replace the following line:

SetBeamCenter(...)

with

SetBeamCenter(10000,0)

  • replace the following line:

DirectBeamTransmission(...)

with

BeamStopTransmission()

The script should then run without crashing.

comment:6 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that the generated script did not crash when changed as above.

comment:8 Changed 9 years ago by Martyn Gigg

  • Status changed from closed to reopened
  • Resolution fixed deleted

The Reduce1D command is missing from the generated script however.

comment:9 Changed 9 years ago by Mathieu Doucet

  • Status changed from reopened to verify
  • Resolution set to fixed

In [14818]:

Fixes #3200

comment:10 Changed 9 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:11 Changed 9 years ago by Martyn Gigg

  • Status changed from verifying to closed

Reduce1D and Save are now back and the script does the same as the GUI.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​4047

Note: See TracTickets for help on using tickets.